Make WordPress Core

Opened 4 years ago

Closed 7 weeks ago

#49756 closed enhancement (wontfix)

Twenty Seventeen: Add gradient background options that fit the theme color scheme

Reported by: ianbelanger's profile ianbelanger Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: good-first-bug has-patch needs-design-feedback close
Focuses: ui Cc:

Description (last modified by ianbelanger)

Now that we have the option for certain blocks to have gradient backgrounds, we need to add gradient background options to the theme that fit the themes color scheme.

Attachments (1)

gradients-in-editor.png (116.2 KB) - added by tomroyer 3 years ago.
Simple-2017-gradients-in-editor

Download all attachments as: .zip

Change History (6)

#1 @ianbelanger
4 years ago

  • Description modified (diff)

This ticket was mentioned in PR #896 on WordPress/wordpress-develop by PerpendicularCure.


3 years ago
#2

  • Keywords has-patch added; needs-patch removed

Added some support for gradient backgrounds on editor blocks

Trac ticket: https://core.trac.wordpress.org/ticket/49756

@tomroyer
3 years ago

Simple-2017-gradients-in-editor

#3 @tomroyer
3 years ago

  • Keywords needs-design-feedback added

I've submitted a pull request using my GitHub account (@PerpendicularCure). This is my first submitted patch. Please let me know if there's anything else expected, or if you have feedback.

#4 @karmatosed
8 weeks ago

  • Keywords close added

For now, default themes are being focused on for bugs not enhancements and this means adding new styling isn't something to look at. This also combines with the fact that as the years have passed a recommended way of adding gradients would be through a theme.json file. All of this leads me to recommend that we close this ticket, so I am going to add the keyword 'close' for now.

Thank you for your collaborations on this and if you do wish to add feedback there is absolutely space for that still. The idea is that we could always come back to this at a later point when we have an approach for older default themes that might involve theme.json's even - it's not decided yet.

#5 @sabernhardt
7 weeks ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I am going to close this. It was discussed in Slack, along with other tickets around gradients, and these were left them open for a few days with the 'close' keyword for feedback.

Thank you everyone for your collaboration.

Note: See TracTickets for help on using tickets.