#49760 closed enhancement (fixed)
Twenty Fifteen: Add gradient background options that fit the theme color scheme
Reported by: | ianbelanger | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 6.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | good-first-bug has-patch commit needs-user-docs |
Focuses: | ui | Cc: |
Description
Now that we have the option for certain blocks to have gradient backgrounds, we need to add gradient background options to the theme that fit the themes color scheme.
Attachments (2)
Change History (17)
This ticket was mentioned in PR #365 on WordPress/wordpress-develop by itsamoreh.
4 years ago
#1
- Keywords has-patch added; needs-patch removed
#2
@
4 years ago
- Keywords needs-patch added; has-patch removed
I submitted a PR for this. I tried to match the theme's color scheme.
This is my first ticket so let me know if I did something wrong!
#4
@
3 years ago
Hi! I tested the PR and it adds gradient background options that fit the theme colour scheme.
This is the background color select before applying the PR:
This is the background color select after applying the PR:
However, I'm experiencing the same behaviour reported in this comment: https://core.trac.wordpress.org/ticket/49761#comment:4 related to twenty fourteen theme.
#6
@
3 years ago
- Owner set to audrasjb
- Status changed from new to reviewing
Self assigning for review
This ticket was mentioned in PR #2280 on WordPress/wordpress-develop by audrasjb.
3 years ago
#7
Trac ticket: https://core.trac.wordpress.org/ticket/49760
#8
@
3 years ago
- Keywords commit added
The patch looks good to me. I put it together in a PR to run unit tests but it looks good to go, thank for testing :)
#10
@
3 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening this ticket because the above commit was reverted, since it was accidentally committed to branch 5.9 instead of trunk…
3 years ago
#12
Committed in https://core.trac.wordpress.org/changeset/52724
3 years ago
#13
Committed in https://core.trac.wordpress.org/changeset/52724
Add theme support and css classes for gradient background options in the twentyfifteen theme.
I used the theme colors for "from" and lightened or darkened by 10% to get the "to" colors.
Trac ticket: https://core.trac.wordpress.org/ticket/49760
Here's a screenshot of the gradients on the buttons:
![ 2020-06-26 at 17 32 37 ](https://user-images.githubusercontent.com/12365909/85903388-33e7cb00-b7d4-11ea-99e8-e48944035d3f.png)