Make WordPress Core

Opened 4 years ago

Closed 6 months ago

#49761 closed enhancement (wontfix)

Twenty Fourteen: Add gradient background options that fit the theme color scheme

Reported by: ianbelanger's profile ianbelanger Owned by:
Milestone: Priority: normal
Severity: normal Version: 6.4
Component: Bundled Theme Keywords: good-first-bug has-patch close
Focuses: ui Cc:

Description

Now that we have the option for certain blocks to have gradient backgrounds, we need to add gradient background options to the theme that fit the themes color scheme.

Attachments (2)

Screenshot 2022-02-04 at 13.47.32.png (102.7 KB) - added by karlijnbk 3 years ago.
Theme colors and new theme gradient colors
gradients.png (261.8 KB) - added by karlijnbk 3 years ago.
Gradient colors on buttons

Download all attachments as: .zip

Change History (10)

#1 @ianbelanger
4 years ago

  • Type changed from defect (bug) to enhancement

This ticket was mentioned in PR #846 on WordPress/wordpress-develop by AdelDima.


4 years ago
#2

  • Keywords has-patch added; needs-patch removed

Add gradient background options (Twenty Fourteen)
Trac ticket: https://core.trac.wordpress.org/ticket/49761

#3 @adeltahri
4 years ago

I submitted a PR for the ticket.

#4 @karlijnbk
3 years ago

Hi! I've tested the PR and the colours look really good, but I might have found one possible problem.

On trunk, when you change the button color to a gradient option, it immediately adds a gradient to the button color. On the PR however, the color is solid and only changes to gradient when I, for example, change the angle.

See the two recordings below for clarification.
Trunk: https://www.loom.com/share/5a4a54d73aad4137a94fcd1c3f4c4fdf
PR: https://www.loom.com/share/3875577390de409aa909e0e9d262fd2d

Version 0, edited 3 years ago by karlijnbk (next)

@karlijnbk
3 years ago

Theme colors and new theme gradient colors

@karlijnbk
3 years ago

Gradient colors on buttons

#5 @devmuhib
13 months ago

  • Keywords close added
  • Version set to trunk

Theme default gradients added. I am using latest twenty fourteen theme to test the feature. It's updated.

#6 @karmatosed
6 months ago

  • Keywords close removed

Reading this ticket it looks like close was added potentially as a mistake because this does have a patch. I am therefore going to remove for now that keyword. It can be re-added.

#7 @karmatosed
6 months ago

  • Keywords close added

After some conversations and considerations I am going to add back the word close. This does absolutely fall into a candidate for closing due to a few things:

  • Default themes are currently being focused on for bugs, not enhancements.
  • The approach for gradients has changed from a few years ago so a different method would be needed across all default themes.

Along with this the desire to do this doesn't seem sure yet. That said, there is opportunity for feedback and the keyword gives that space. Thank you everyone for your collaboration so far.

#8 @karmatosed
6 months ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I am going to close this as it was discussed in Slack, along with other tickets around gradients. I am closing them all together after having left them open for a few days with the close keyword for feedback. Thank you everyone for your collaboration.

Note: See TracTickets for help on using tickets.