#49772 closed defect (bug) (fixed)
Support additional elements (table, ol, ul) in privacy policy guide new styling
Reported by: | garrett-eclipse | Owned by: | garrett-eclipse |
---|---|---|---|
Milestone: | 5.4.1 | Priority: | normal |
Severity: | normal | Version: | 5.4 |
Component: | Privacy | Keywords: | has-patch has-screenshots commit |
Focuses: | ui, css, administration | Cc: |
Description (last modified by )
With 5.4 (r47147 / #44621) the privacy policy guide aesthetic was updated to introduce a white background on the suggested text. In the CSS this only applies to paragraph elements (<p>
).
Reviewing some other plugin implementations there is at minimum a need to also support <ul>
, <ol>
, and <table>
elements.
*I've only gone through the top 15 plugins from the link above so further investigation is in order.
This primarily comes from a comment on the woocommerce PR here;
"Tested in WP 5.0 and 5.3.2, and in both cases the difference is that <p> sections inside the "Source: WooCommerce" section appear in italics after applying the changes; other elements (mostly <li>) appear unchanged. Is this the expected behavior?"
While it refers to pre-5.4 the issue persists and gets worse in 5.4 in that it's not just italics but now padding and background which becomes jarring when it goes from a paragraph (styled) to a list (unstyled) and back to paragraph (styled).
The white background in 5.4 is meant to denote the content being copied and as such should encompass these other elements;
p - already does
h# - shouldn't as the design excludes them
hr - maybe
ul - yes, used in plugins (example)
ol - yes, used in plugins (example)
table - yes, used in plugins - (example)
div - potentially
... - Open to others as well.
Also note the list items aren't denoted with bullet points in the current design. This makes them look like paragraphs and could be confusing.
Attachments (6)
Change History (15)
#3
@
5 years ago
- Keywords has-patch has-screenshots needs-testing added
- Milestone changed from Awaiting Review to 5.4.1
- Owner set to garrett-eclipse
- Status changed from new to accepted
- Version set to 5.4
In 49772.diff I've worked through several attempts and am now happy with the result and support of plugins that contain alternate elements (ul, ol, table) inside the suggested content.
Along with handling these I've also applied basic styling to the ul/ol to indent and ensure it's prefixed properly with either the disc or numeric.
This ticket was mentioned in Slack in #core by whyisjake. View the logs.
5 years ago
#6
in reply to:
↑ 4
@
5 years ago
Replying to whyisjake:
Looks great @garrett-eclipse. Ready to commit?
For sure, would love some testers to apply the patch and then some 3rd party plugins just to be extra safe here.
Here's a list of plugins using the guide - https://wpdirectory.net/search/01E4VTZDVQY3Y4JJC8T51WGZHW
*WooCommerce, The Events Calendar and other larger ones are the primary focus.
This example from WooCommerce shows the heading, a suggested paragraph, a suggested list (no bg or bullets), another suggested paragraph and finally a tutorial note. The list is left out of place even though it will be part of the copied content.