Twenty Nineteen: Text color isn't reflected

[karmatosed]

The new text color feature doesn't work in Twenty Nineteen, you are unable to change the text color.

[samful]

CSS Only patch (needs to be made into SCSS)

[samful]

The styles were not being included in the "twentynineteen/style-editor.css" file, I uploaded a patch putting css directly in here, but someone needs to convert this to SCSS and add it to "twentynineteen/style-editor.scss" file.

I tested and 2017 and 2020 do not have this issue.

[samful]

full patch with SCSS

[samful]

Added full patch with SCSS, this was my first time using SASS, so if a SASSY master would look over it for me that would be great!

[ryelle]

I updated the patch to use the same colors as in /sass/blocks/_blocks.scss, and removed the .has-inline-color since it's not technically necessary. This only fixes the issue for the default colors, though.

It's possible to change the primary color in the customizer, and the colors are not updated in the editor. Twenty Twenty had the same issue, see this comment on #50120. The generated CSS in /inc/color-patterns.php needs to be updated.

[smit08]

Hi @karmatosed i have tested it in wordpress 2019 theme and i found it that the text color tool is working, but it is not working on some particular colors like primary, secondary, dark grey etc. But it is working on white and shades of yellow. I am attaching the screen-shot of it.

Testing steps:

1. wp v5.8.1
2. theme Twenty Nineteen
3. add text color on text. add color like primary, secondary, dark grey etc.

screenshot link: ​https://prnt.sc/1wzcbo8

[smit08]

screenshot that shows some colors are working in text color tool and some are not working.

[smit08]

In 2019 theme only primary, secondary and dark green color required the editor css so i created a patch for this 3 colors only.

[poena]

Hi @smit08
Twenty Nineteen uses SCSS and custom SCSS variables. The scss files needs to be compiled/built to create .css files.

Changes made directly to the style-editor.css are overwritten during that build process.
That is why it is not enough to change only style-editor.css.

.has-inline-color is not necessary.

@ryelle mentioned that the primary color can be customized, and that changing the CSS files is not enough to solve the full issue.

Here is how to confirm that:

1) Activate the theme.
2) Open the customizer.
3) Open the colors and select "custom". Set a color, save.
4) Open the block editor.
5) Select a text like a paragraph block and select "highlight" via the block toolbar settings. Select the primary color that you just changed.
6) Confirm that the text is still blue, not the custom color.

[sabernhardt]

With 5.9 Beta 1 release happening in a few hours, moving this ticket to future release.

[sabernhardt]

#56960 was marked as a duplicate.