Opened 16 months ago
Last modified 3 weeks ago
#49787 assigned defect (bug)
Twenty Nineteen: Text color isn't reflected
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.9 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Bundled Theme | Keywords: | needs-patch |
| Focuses: | css | Cc: |
Description
The new text color feature doesn't work in Twenty Nineteen, you are unable to change the text color.
Attachments (3)
Change History (11)
#1
@
16 months ago
- Component changed from Themes to Bundled Theme
- Summary changed from Text color isn't reflected in Twenty Nineteen to Twenty Nineteen: Text color isn't reflected
#2
@
15 months ago
- Focuses css added
- Keywords needs-refresh added; needs-patch removed
The styles were not being included in the "twentynineteen/style-editor.css" file, I uploaded a patch putting css directly in here, but someone needs to convert this to SCSS and add it to "twentynineteen/style-editor.scss" file.
I tested and 2017 and 2020 do not have this issue.
#3
@
15 months ago
- Keywords has-patch added; needs-refresh removed
Added full patch with SCSS, this was my first time using SASS, so if a SASSY master would look over it for me that would be great!
This ticket was mentioned in Slack in #core-themes by sabernhardt. View the logs.
8 months ago
This ticket was mentioned in Slack in #core-css by sabernhardt. View the logs.
8 months ago
#6
@
7 weeks ago
- Keywords needs-patch added; has-patch removed
- Milestone changed from Awaiting Review to 5.9
I updated the patch to use the same colors as in /sass/blocks/_blocks.scss, and removed the .has-inline-color since it's not technically necessary. This only fixes the issue for the default colors, though.
It's possible to change the primary color in the customizer, and the colors are not updated in the editor. Twenty Twenty had the same issue, see this comment on #50120. The generated CSS in /inc/color-patterns.php needs to be updated.
CSS Only patch (needs to be made into SCSS)