WordPress.org

Make WordPress Core

Opened 13 months ago

Last modified 5 months ago

#49787 new defect (bug)

Twenty Nineteen: Text color isn't reflected

Reported by: karmatosed Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: css Cc:

Description

The new text color feature doesn't work in Twenty Nineteen, you are unable to change the text color.

http://cldup.com/M49Ikw3xxW.png

Attachments (2)

49787.diff​ (767 bytes) - added by samful 12 months ago.
CSS Only patch (needs to be made into SCSS)
49787.2.diff​ (2.2 KB) - added by samful 12 months ago.
full patch with SCSS

Download all attachments as: .zip

Change History (7)

#1 @SergeyBiryukov
13 months ago

  • Component changed from Themes to Bundled Theme
  • Summary changed from Text color isn't reflected in Twenty Nineteen to Twenty Nineteen: Text color isn't reflected

@samful
12 months ago

CSS Only patch (needs to be made into SCSS)

#2 @samful
12 months ago

  • Focuses css added
  • Keywords needs-refresh added; needs-patch removed

The styles were not being included in the "twentynineteen/style-editor.css" file, I uploaded a patch putting css directly in here, but someone needs to convert this to SCSS and add it to "twentynineteen/style-editor.scss" file.

I tested and 2017 and 2020 do not have this issue.

@samful
12 months ago

full patch with SCSS

#3 @samful
12 months ago

  • Keywords has-patch added; needs-refresh removed

Added full patch with SCSS, this was my first time using SASS, so if a SASSY master would look over it for me that would be great!

This ticket was mentioned in ​Slack in #core-themes by sabernhardt. ​View the logs.
5 months ago

This ticket was mentioned in ​Slack in #core-css by sabernhardt. ​View the logs.
5 months ago

Note: See TracTickets for help on using tickets.