WordPress.org

Make WordPress Core

Opened 6 months ago

Last modified 12 days ago

#49831 assigned defect (bug)

Multisite: themes should not be allowed to be updated from the Appearance > Themes screen of a subsite

Reported by: pbiron Owned by: pbiron
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-screenshots has-patch needs-testing
Focuses: multisite Cc:

Description

In a multisite installation, plugin updates are are not displayed on subsite Plugins screen...and to update a plugin you must be on the Network Admin > Plugins screen.

However, themes can be updated from the subsite Themes screen (see screenshot). What is really odd, is that in the Theme Details modal on subsites, the fact that an update is available is shown, but you can't actually update :-)

Attachments (4)

theme-update-in-subsite.png (233.8 KB) - added by pbiron 6 months ago.
theme-details-modal-in-subsite.png (55.4 KB) - added by pbiron 6 months ago.
49831.diff (1.8 KB) - added by afragen 12 days ago.
49831.1.diff (1.1 KB) - added by pbiron 12 days ago.

Download all attachments as: .zip

Change History (10)

#1 @pbiron
6 months ago

  • Keywords has-screenshots added

This ticket was mentioned in Slack in #core-auto-updates by pbiron. View the logs.


12 days ago

#3 @pbiron
12 days ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.6
  • Owner set to pbiron
  • Status changed from new to assigned

@afragen
12 days ago

#4 @afragen
12 days ago

  • Keywords has-patch needs-testing added; needs-patch removed

49831.diff seems to work but needs testing.

Last edited 12 days ago by afragen (previous) (diff)

@pbiron
12 days ago

#5 @pbiron
12 days ago

49831.1.diff takes a different approach than 49831.diff.

Instead of just hiding the update link, it doesn't even show the "Update Available" banner. It also results in updates not showing as being available in the Customizer.

I think this approach brings the Themes screen into parity with the Plugins screen, where the fact that updates are available is also not displayed.

This patch also needs testing :-)

#6 @afragen
12 days ago

Preliminary testing shows both patches function as they are designed.

I think bringing parity with plugins is probably a better idea.

Note: See TracTickets for help on using tickets.