Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 6 years ago

Closed 6 years ago

#49833 closed enhancement (fixed)

Twenty Twenty: HTML in featured image caption is being escaped

Reported by:	pierlo	Owned by:	ianbelanger
Priority:	normal	Milestone:	5.5
Component:	Bundled Theme	Version:	5.3
Severity:	normal	Keywords:	has-patch good-first-bug has-screenshots
Cc:		Focuses:

Description

Featured images that contain HTML in their captions are being escaped in Twenty Twenty. A valid case for having HTML here would be to link to the original source the image was taken, or even a way to credit the author of the image.

Attachments (2)

49833.diff (652 bytes ) - added by pierlo 6 years ago.
Capture d’écran 2020-05-23 à 11.07.14.png (207.9 KB ) - added by audrasjb 6 years ago.: Testing the patch with various HTML elements

Download all attachments as: .zip

Change History (12)

@pierlo
6 years ago

Attachment 49833.diff added

#1 @pierlo
6 years ago

Keywords has-patch added

#2 @spacedmonkey
6 years ago

Version → 5.3

#3 @spacedmonkey
6 years ago

Keywords good-first-bug 2nd-opinion added

#4 @JavierCasares
6 years ago

Keywords has-screenshots added

Works for me.

vs

#5 @spacedmonkey
6 years ago

Milestone Awaiting Review → 5.5

@audrasjb
6 years ago

Attachment Capture d’écran 2020-05-23 à 11.07.14.png added

Testing the patch with various HTML elements

#6 @audrasjb
6 years ago

Keywords commit added; 2nd-opinion removed
Owner set to audrasjb
Status new → accepted

I tested 49833.diff with various HTML elements and it looks good to me.

Removing 2nd-opinion and marking this ticket for commit.

#7 @ianbelanger
6 years ago

Owner changed from audrasjb to ianbelanger
Status accepted → assigned

Reviewing for commit.

#8 @ianbelanger
6 years ago

Resolution → fixed
Status assigned → closed

Bundled Themes: Twenty Twenty HTML in featured image caption is being escaped.

Fixes the issue by replacing esc_html with wp_kses_post in the caption in featured images.

Props pierlo, JavierCasares, audrasjb.
Fixes #49833.

#9 @ianbelanger
6 years ago

Keywords fixed-major added; commit removed
Milestone 5.5 → 5.4.3
Resolution fixed
Status closed → reopened

Reopening for backport.

#10 @desrosj
6 years ago

Keywords fixed-major removed
Milestone 5.4.3 → 5.5
Resolution → fixed
Status reopened → closed

With 5.5 just under 5 weeks away, there is no 5.4.3 planned. Moving back to the 5.5 milestone.

Note: See TracTickets for help on using tickets.

Download in other formats: