WordPress.org

Make WordPress Core

Opened 7 weeks ago

Last modified 2 days ago

#49833 accepted enhancement

Twenty Twenty: HTML in featured image caption is being escaped

Reported by: pierlo Owned by: audrasjb
Milestone: 5.5 Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: has-patch good-first-bug has-screenshots commit
Focuses: Cc:

Description

Featured images that contain HTML in their captions are being escaped in Twenty Twenty. A valid case for having HTML here would be to link to the original source the image was taken, or even a way to credit the author of the image.

Attachments (2)

49833.diff (652 bytes) - added by pierlo 7 weeks ago.
Capture d’écran 2020-05-23 à 11.07.14.png (207.9 KB) - added by audrasjb 2 days ago.
Testing the patch with various HTML elements

Download all attachments as: .zip

Change History (8)

@pierlo
7 weeks ago

#1 @pierlo
7 weeks ago

  • Keywords has-patch added

#2 @spacedmonkey
7 weeks ago

  • Version set to 5.3

#3 @spacedmonkey
4 weeks ago

  • Keywords good-first-bug 2nd-opinion added

#4 @JavierCasares
9 days ago

  • Keywords has-screenshots added

Works for me.

https://i.ibb.co/vYQNrYZ/Screenshot-241.png

vs

https://i.ibb.co/2jf30Nt/Screenshot-242.png

#5 @spacedmonkey
7 days ago

  • Milestone changed from Awaiting Review to 5.5

@audrasjb
2 days ago

Testing the patch with various HTML elements

#6 @audrasjb
2 days ago

  • Keywords commit added; 2nd-opinion removed
  • Owner set to audrasjb
  • Status changed from new to accepted

I tested 49833.diff with various HTML elements and it looks good to me.

Removing 2nd-opinion and marking this ticket for commit.

Note: See TracTickets for help on using tickets.