WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

#49838 closed defect (bug) (fixed)

Freedoms page: the headings hierarchy skips one level

Reported by: afercia Owned by: afercia
Milestone: 5.4.1 Priority: normal
Severity: normal Version: 5.4
Component: Administration Keywords: has-screenshots has-patch fixed-major
Focuses: accessibility, css Cc:

Description

In the Freedoms page wp-admin/freedoms.php, the headings hierarchy skips one level.

All the h3 headings should be bumped up by one level.

Attachments (5)

freedoms hierarchy.png (285.0 KB) - added by afercia 6 months ago.
49838.diff (1.6 KB) - added by afercia 6 months ago.
smaller-h2.png (204.0 KB) - added by ryelle 6 months ago.
Patch applied, h2s are styled smaller to match h3
default-h2.png (207.4 KB) - added by ryelle 6 months ago.
Default h2, no styles applied to shrink them
49838.2.diff (1.7 KB) - added by afercia 6 months ago.

Download all attachments as: .zip

Change History (11)

@afercia
6 months ago

#1 @afercia
6 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 5.4.1
  • Owner set to afercia
  • Status changed from new to assigned

49838.diff tries to adopt the CSS new naming convention specific to the "about.css" file. It introduces a CSS class has-smaller-headings to visually render H2 like they were H3. Please do let me know if this approach is OK @melchoyce @ryelle

@ryelle
6 months ago

Patch applied, h2s are styled smaller to match h3

@ryelle
6 months ago

Default h2, no styles applied to shrink them

#2 @ryelle
6 months ago

I've attached a screenshot of the patch applied. For curiosity I also added a screenshot of using default h2s, which probably are too big :) So shrinking them down makes sense. I would change the class to be on the headings themselves, since that's what they affect— something like is-smaller-heading.

@afercia
6 months ago

#3 @afercia
6 months ago

Thanks. Patch updated.

#4 @afercia
6 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 47558:

Accessibility: Fix the headings hierarchy on the Freedoms page.

Props ryelle, afercia.
Fixes #49838.

#5 @afercia
6 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 5.4.1 consideration.

#6 @whyisjake
6 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 47566:

Accessibility: Fix the headings hierarchy on the Freedoms page.

Props ryelle, afercia.
Bring r47558 to the 5.4 branch.

Fixes #49838.

Note: See TracTickets for help on using tickets.