Make WordPress Core

Opened 3 years ago

Last modified 4 days ago

#49850 new enhancement

Adding Anghami to the list of oembed providers

Reported by: azizantoun's profile azizantoun Owned by:
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch
Focuses: Cc:

Description

Anghami is the leading streaming website in the middle east. (www.anghami.com)
This is a request ticket to add the Anghami oembed schema to the wp-oembed.php list of providers.

'#https?:((play|www)\.)?anghami\.com/.*#i' => array( 'https://www.anghami.com/oembed', true )

Attachments (1)

Capture d’écran 2020-05-23 à 13.59.38.png (181.6 KB) - added by audrasjb 3 years ago.
Upstream JS error

Download all attachments as: .zip

Change History (14)

#1 follow-up: @swissspidy
3 years ago

  • Component changed from General to Embeds

Hi there

Would you be able to help us fill out the required information as per https://make.wordpress.org/core/handbook/contribute/design-decisions/#whitelisting-oembed-providers?

#2 @desrosj
3 years ago

  • Keywords reporter-feedback added

#3 in reply to: ↑ 1 @azizantoun
3 years ago

Hello,

Thank you for getting back to me. I will write the answers in the comment box is that enough?

Is the service is popular enough for core developers to have heard of it before? Is it “mainstream?

Anghami is the leading music streaming service in the middle east with more than 80 million users. We have a catalogue of millions f arabic and international songs and music videos. Anghami also has series/movies and podcasts. You can check www.anghami.com for more details.

If similar services are already supported, how does this service compare in terms of size, features, and backing?

Spotify and Deezer are similar services. The main difference is that Anghami provides music videos and series. Anghami also has stories, chats and other social feature that differentiates it from any other music streaming service.

Does this service have a large following on Twitter, Facebook, or other social media?  Is its Twitter account verified?
Yes Anghami has millions of followers on social networks.
https://twitter.com/anghami
https://facebook.com/anghami
https://instagram.com/anghami

Is its oEmbed endpoint clearly established and properly documented? (Sometimes, they are just a developer’s pet project that may not be supported.)
Yes, our media pages (song,album,playlist,artist,profile) support oembed. The Oembed url points to our custom built widget.
example: https://widget.anghami.com/playlist/5890887

Does the oEmbed endpoint work with WordPress’ oEmbed auto-discovery? If not, could it be made to work with additional HTML tags or attributes being whitelisted?

On our blog it's working after manually adding anghami to the list of oembed providers using the following method: wp_oembed_add_provider. Here's a live article showing our widget loaded via oembed. https://talks.anghami.com/anghami-how-we-shifted-to-work-from-home-on-covid19-with-little-notice/

Does the service make an effort to build relationships with developers, such as through robust APIs?

We have recently opened our APIs to the public to allow developer and interns to use our data and create projects around music

How old is the service?

Anghami was founded in 2011 and launched the first beta app in 2012

Does it have a well-established Wikipedia article?

https://en.wikipedia.org/wiki/Anghami

Has anyone written a WordPress plugin that leverages the service in some way, whether adding it as an oEmbed provider, creating a shortcode, or leveraging other APIs of the service? Do these plugins have any noticeable adoption or traction that would indicate usage and demand?

Not yet

Is the provider frequently proposed?

Lots of articles in the middle east talk about Anghami and share news related to the music industry. Currently publishers get their embed code from www.anghami.com/embed and paste the iframe in their wordpress articles. By whitelisting Anghami the process will become easier for them, pasting the link should load the widget similar to any other service. Currently we have thousands of daily visits to our widgets embdded on hundreds of articles

I hope my answers were clear. Looking forward to your feedback.

Replying to swissspidy:

Hi there

Would you be able to help us fill out the required information as per https://make.wordpress.org/core/handbook/contribute/design-decisions/#whitelisting-oembed-providers?

#4 @johnbillion
3 years ago

  • Keywords reporter-feedback removed
  • Milestone changed from Awaiting Review to 5.5

Moving this to the next major milestone for consideration as we always do for oEmbed whitelisting requests.

#5 @audrasjb
3 years ago

  • Keywords reporter-feedback added

Hi,

@azizantoun: I tried to whitelist this oEmbed provider in WordPress Core, but the embed throws a JS external resource error.
I think it has to be fixed upstream.

See screenshot below.

#6 @audrasjb
3 years ago

Here is the URL I used in my test: https://play.anghami.com/playlist/5890887

#7 @azizantoun
3 years ago

Hi @audrasjb,

Thank you for your reply. We had an API limitation on localhost. It was preventing the widget from loading on your local environment. We removed the rule now, the widget should load fine on your end.
Thanks

#8 @audrasjb
3 years ago

Hi @azizantoun thanks for your feedback,

There is still a JS error:

xxxx.chunk.js:1 TypeError: Cannot read property 'hexcolor' of null

#9 @audrasjb
3 years ago

(it results to the same white embed I already shared in the above screenshot)

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


3 years ago

#11 @audrasjb
3 years ago

  • Milestone changed from 5.5 to Future Release

Moving to Future release as we are close to WP 5.5 beta 1 and there are still upstream issue.

Last edited 3 years ago by audrasjb (previous) (diff)

This ticket was mentioned in PR #4524 on WordPress/wordpress-develop by @swissspidy.


4 days ago
#12

  • Keywords has-patch added; needs-patch removed

#13 @swissspidy
4 days ago

  • Keywords reporter-feedback removed
  • Milestone changed from Future Release to 6.3

Looks like the new endpoint is https://api.anghami.com/rest/v1/oembed.view

The provided regex above is also incorrect, it should be #https?://((play|www)\.)?anghami\.com/.*#i (notice the added slashes after https:)

No JS errors when testing the provider.

Note: See TracTickets for help on using tickets.