Use feature image of video attachment as preview instead of icon

[spacedmonkey]

In the media library list view, it currently shows a video icon. A user is able to selected featured image for video attachments ( used for poster image in video tag ). If a feature image is set for a video attachment, show this instead of the icon.

[samful]

samful's patch for video thumbnails not appearing on list view

[samful]

I managed to replicate this and fix it in the "wp-admin/includes/class-wp-media-list-table.php" file and submitted a patch.

Using my patch seems to use the featured image of the video (if set) instead of the icon in list view and solve the issue.

This is my first bug fix, I hope it helps :)

[johnbillion]

Thanks for the patch @samful and welcome to WordPress Trac!

Some feedback on your patch, as it's your first one:

• It looks like the formatting of your patch file isn't right, here's a guide for creating a patch file correctly: ​https://make.wordpress.org/core/handbook/tutorials/trac/submitting-a-patch/
• Not all videos will have a featured image, so we'll need some logic which only uses the featured image ID if one exists, and still uses the ID of the video attachment if not so the correct icon is displayed.
• Audio files can actually have a featured image too, although this is not a commonly used feature. They're used if you create an audio playlist in the classic editor. We might as well add support for featured images for audio too.

Feel free to resubmit your patch using the same file name, and just ask here if you have any questions.

[samful]

samful's patch for video and audio thumbnails not appearing on list view

[samful]

Thank you for the feedback @johnbillion, very much appreciated.

• Formatting should be correct now.
• Logic has been added to keep using the video/audio ID if a featured image doesn't exist.
• Audio featured images have now been fixed in the same style as the video ones.

[samful]

fixed a silly mistake where i left the array in quotes...

[JavierCasares]

vs

[JavierCasares]

Also, works great :)

[samful]

refreshed with proper /src path and line numbers

[seanchayes]

I downloaded 49852.4.patch and applied it to my local trunk installation.

To test it out I did the following:

• I added a new video file to the media library.
• In the media library list view the video I uploaded showed a default thumbnail.
• I edited the media item and chose a featured image and clicked update.
• I returned to the media library list view and saw that now my featured image selection was being used as the thumbnail for my video file.
• I successfully repeated the same test with an audio file.

To that end 49852.4.patch tested out successfully.

I iterated on 49852.4.patch, made some coding standards changes (no functional changes) and have submitted 49852.5.diff for consideration.

[seanchayes]

Updated spacing matching coding standards - no functional changes

[antpb]

#55164 was marked as a duplicate.

[cadic]

Code styles: Yoda conditions, strict comparison, spacing

Trac ticket: https://core.trac.wordpress.org/ticket/49852

[mukesh27]

@cadic Left one miner change request in PR.

@cadic Looks good to me. Left one miner change.

Thanks @mukeshpanchal27, what was the request?

Check now

[spacedmonkey]

Given my feedback. Good work. @cadic

[cadic]

@spacedmonkey thank you for the suggestion. I just curious, isn't it a potential performance issue? Using wp_attachment_is() twice inside a loop on the $post object which was already processed during upload and have assigned post_mime_type attribute?

[cadic]

@spacedmonkey oh, nevermind, I see it will use post_mime_type early if it exists!

[spacedmonkey]

@cadic Didn't say it was a performance issue.

This check mirrors ​this. A developer could filter wp_get_audio_extensions or wp_get_video_extensions. So we have to use wp_attachment_is.

[JeffPaul]

@spacedmonkey probably too late for 6.1, but if that patch looks good then perhaps we milestone for 6.2 and mark for commit?

[spacedmonkey]

@JeffPaul I would be happy to commit as it is a small change, but I will defer to you on this one.

Trac ticket: https://core.trac.wordpress.org/ticket/49852

[spacedmonkey]

@cadic I have updated the patch to ensure that caches are primed and made the logic a little simpler. If you are happy with the changes, I will commit.

[spacedmonkey]

In 54941:

Media: Use featured image if available for attachment as preview instead of icon.

When rendering a list of attachments in WP_Media_List_Table class, none image attachments, show a generic icon. However, attachment types like audio and video support adding a featured image. For attachments that have featured images, us this image instead of the icon. This featured image is a better preview than a generic icon.

Props spacedmonkey, samful, johnbillion, JavierCasares, seanchayes, antpb, cadic, JeffPaul.
Fixes #49852.