WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#49861 closed enhancement (fixed)

Emoji javascript comment

Reported by: superpoincare Owned by: SergeyBiryukov
Priority: normal Milestone: 5.5
Component: Build/Test Tools Version: 5.4
Severity: normal Keywords:
Cc: Focuses: javascript

Description

The line 


/*! This file is auto-generated */

appears in the front end of the emoji code in the head

It look unusual for it to appear in html.

Change History (2)

#1 @SergeyBiryukov
6 years ago

  • Component General → Build/Test Tools
  • Milestone Awaiting Review → 5.5

Thanks for the ticket!

Introduced in [46589] / #48424.

It seems like we could either:

  • Remove the banner from wp-emoji-release.min.js.
  • Or (preferably) use ​grunt-include-replace instead of ​grunt-includes for including the file, since it doesn't look like the latter can remove something from the file contents before including.

#2 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 48096:

Build/Test Tools: Replace the banner text from wp-emoji-loader.min.js in formatting.php during build process.

This ensures that /*! This file is auto-generated */ comment is not included on front end as part of the inline Emoji detection script.

Follow-up to [41271], [46589].

Props superpoincare, SergeyBiryukov.
Fixes #49861.

Note: See TracTickets for help on using tickets.