WordPress.org

Make WordPress Core

Opened 7 weeks ago

#49863 new defect (bug)

Twenty Nineteen: Button block editor styles need a refresh

Reported by: kjellr Owned by:
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: needs-patch
Focuses: Cc:

Description

Post WordPress 5.4, the Gutenberg plugin now syncs up the button markup in the editor with what's rendered on the front end:

https://github.com/WordPress/gutenberg/pull/21266#issuecomment-611344160

Old button markup:

<!-- wp:button -->
<div class="wp-block-button"><a class="wp-block-button__link">My button</a></div>
<!-- /wp:button -->

New button markup:

<!-- wp:button -->
<a class="wp-block-button wp-block-button__link">My button</a>
<!-- /wp:button -->

Twenty Nineteen's editor styles for the button block currently target the .wp-block-button__link selector as a child of the wp-block-button separator, but that's no longer the case. As a result, these button editor styles aren't getting picked up when using the Gutenberg plugin.

This should be corrected. In order to provide compatibility with earlier Gutenberg versions, changes here should probably end up preserving the old selectors too.

Change History (0)

Note: See TracTickets for help on using tickets.