Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#49867 closed defect (bug) (fixed)

Bundled themes: Incorrect punctuation for the comment preview string ($moderation_note)

Reported by: llizard's profile llizard Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: ui-copy Cc:

Description

In the Twenty Twelve theme, the punctuation for the comment preview string of $moderation_note is incorrect.

This is the coding in the functions file for the twentytwelve theme:

$commenter = wp_get_current_commenter();
				if ( $commenter['comment_author_email'] ) {
					$moderation_note = __( 'Your comment is awaiting moderation.', 'twentytwelve' );
				} else {
					$moderation_note = __( 'Your comment is awaiting moderation. This is a preview, your comment will be visible after it has been approved.', 'twentytwelve' );
				}

It is possible that other WP themes' functions files have something similar, because when I searched "This is a preview, your comment will be visible after it has been approved", various WP Twenty Something themes appeared (recent ones as well as this earlier twentytwelve).

I have been unable to discover how to change the wording within my own Twenty Twelve child theme's functions file. (I have asked for help on this on two occasions but it appears that anyone looking in the WP forums doesn’t know the answer either.)

Therefore, in the next update of WP themes Twenty Twelve (and whichever of the Twenty series themes the phrase occurs), please correct the punctuation in the following string

"This is a preview, your comment will be visible after it has been approved."

Please note that the comma after 'preview' does not belong. The sentence should read:

This is a preview; your comment will be visible after it has been approved.

OR

This is a preview – your comment will be visible after it has been approved.

OR

This is a preview. Your comment will be visible after it has been approved.

Of course, it may seem like a small thing to have to fix, but grammar teachers will be most appreciative if it is corrected at last. As would I. Thank you.

Attachments (1)

49867.diff (780 bytes) - added by mayankmajeji 4 years ago.
Punctuation Error Corrected - Twenty Twenty Theme

Download all attachments as: .zip

Change History (7)

#1 @SergeyBiryukov
4 years ago

  • Component changed from General to Bundled Theme
  • Focuses ui-copy added

@mayankmajeji
4 years ago

Punctuation Error Corrected - Twenty Twenty Theme

#2 @mayankmajeji
4 years ago

  • Keywords has-patch added

#3 @llizard
4 years ago

  • Summary changed from Incorrect punctuation for the comment preview string ($moderation_note) in Twenty Twelve and possibly other Twenty themes to Incorrect punctuation for the comment preview string ($moderation_note) in Twenty Twelve

Unfortunately, in the recent (August 2020) update of WP's twentytwelve theme, this grammatical error has still not been corrected.

To reiterate, please note that the comma does not belong after preview in the string This is a preview, your comment will be visible after it has been approved. The string should read:

This is a preview; your comment will be visible after it has been approved.

OR

This is a preview – your comment will be visible after it has been approved.

OR

This is a preview. Your comment will be visible after it has been approved.

Please fix this.

#4 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 5.6
  • Summary changed from Incorrect punctuation for the comment preview string ($moderation_note) in Twenty Twelve to Bundled themes: Incorrect punctuation for the comment preview string ($moderation_note)

Thanks for the ticket! Just noting the list of all affected themes here:

  • Twenty Ten
  • Twenty Eleven
  • Twenty Twelve
  • Twenty Nineteen

#5 @SergeyBiryukov
4 years ago

In 48824:

Comments: Correct punctuation in "Your comment is awaiting moderation" string in Walker_Comment.

Props llizard.
See #49867.

#6 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 48825:

Bundled Themes: Correct punctuation in "Your comment is awaiting moderation" string.

Props llizard, mayankmajeji.
Fixes #49867.

Note: See TracTickets for help on using tickets.