Opened 4 years ago
Closed 4 years ago
#49872 closed defect (bug) (fixed)
PHP Notice: Undefined index: path in /wp-includes/functions.php on line 905
Reported by: | jbouganim | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.5 | Priority: | normal |
Severity: | normal | Version: | 4.4 |
Component: | Pings/Trackbacks | Keywords: | has-patch needs-unit-tests |
Focuses: | Cc: |
Description
Some URLs here do not have a 'path' and thus throw this notice.
Instead of only checking on /wp-includes/functions.php L904:
<?php if ( false !== $url_parts )
should also check
<?php if ( false !== $url_parts && !empty($url_parts['path']) )
Attachments (1)
Change History (7)
#1
@
4 years ago
- Component changed from General to Pings/Trackbacks
- Keywords has-patch added
- Severity changed from minor to normal
- Version changed from 5.4 to 4.4
Hi, @jbouganim,
Welcome to WordPress Trac! Thanks for the ticket.
Added initial patch as suggested.
#3
@
4 years ago
@Otto42 Sure.
<?php $url_parts = parse_url("https://redirect.viglink.com?key=2fb2035e82f6fb61e704bd9&u=https%3A%2F%2Fwww.michaels.com%2Fsearch%3Fq%3Dbandana");
Will not have a path
index.
#4
@
4 years ago
- Keywords needs-unit-tests added
Great! So probably need some unit tests added to go with this as well.
Note: See
TracTickets for help on using
tickets.
Initial patch.