WordPress.org

Make WordPress Core

Opened 6 weeks ago

Closed 9 days ago

#49893 closed enhancement (fixed)

TwentyTwenty: TikTok and ResearchGate Social Icons

Reported by: mislavjuric Owned by: ianbelanger
Milestone: 5.4.2 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots has-patch commit fixed-major
Focuses: Cc:

Description

Hello guys,

It seems that Twenty Twenty doesn’t have icons for ResearchGate and TikTok social media. I have the profiles on those social networks linked up on my website and would like to have icons of those two social networks displayed as well.

Could someone add these?

Thank you in advance!

Attachments (9)

49893.diff (3.1 KB) - added by audrasjb 6 weeks ago.
Bundled Themes: Twenty Twenty: Add TikTok to Social Menu
Capture d’écran 2020-04-13 à 15.56.24.png (114.9 KB) - added by audrasjb 6 weeks ago.
Bundled Themes: Twenty Twenty: Add TikTok to Social Menu
class-twentytwenty-svg-icons.php (65.4 KB) - added by audrasjb 6 weeks ago.
49893.1.diff (5.7 KB) - added by audrasjb 6 weeks ago.
Bundled Themes: Twenty Twenty: Add TikTok to Social Menu
49893-no-icon.png (3.7 KB) - added by ianbelanger 6 weeks ago.
49893.2.diff (3.8 KB) - added by audrasjb 6 weeks ago.
Bundled Themes: Twenty Twenty: Add TikTok to Social Menu
tik.svg (2.8 KB) - added by Emlebrun 2 weeks ago.
Logo TikTok Svg
49893.3.diff (5.3 KB) - added by audrasjb 2 weeks ago.
Bundled Themes: Replace TikTok icon with GPLv2 compatible SVG
Capture d’écran 2020-05-11 à 17.22.55.png (12.9 KB) - added by audrasjb 2 weeks ago.
Bundled Themes: Replace TikTok icon with GPLv2 compatible SVG (screenshot of the new icon)

Download all attachments as: .zip

Change History (37)

@audrasjb
6 weeks ago

Bundled Themes: Twenty Twenty: Add TikTok to Social Menu

@audrasjb
6 weeks ago

Bundled Themes: Twenty Twenty: Add TikTok to Social Menu

#1 follow-up: @audrasjb
6 weeks ago

  • Keywords has-patch has-screenshots added
  • Owner set to audrasjb
  • Status changed from new to accepted

Hi @mislavjuric, welcome to WordPress Core Trac and thank you for opening this ticket,

49893.diff implements TikTok icon to Twenty Twenty’s Social Menu.

Unfortunately, I can't find a good SVG markup for ResearchGate logo.
@mislavjuric could you help ton find this SVG asset, please?

Cheers,
Jb

#2 @poena
6 weeks ago

This is just my opinion but I feel strongly that the icons in the default themes should be consistent between the themes but also consistent with the block editor.

#3 @audrasjb
6 weeks ago

  • Keywords commit added

@poena In my opinion, you're right.
Let's wait for ResearchGate Embed to be implemented in the Editor.

Then, let's add commit workflow keyword for the TikTok part only (as it was introduced in WordPress Embeds in WP 5.4) :)

#4 in reply to: ↑ 1 ; follow-up: @mislavjuric
6 weeks ago

Replying to audrasjb:

Hi @mislavjuric, welcome to WordPress Core Trac and thank you for opening this ticket,

49893.diff implements TikTok icon to Twenty Twenty’s Social Menu.

Unfortunately, I can't find a good SVG markup for ResearchGate logo.
@mislavjuric could you help ton find this SVG asset, please?

Cheers,
Jb

Hey, I've got two questions:

1) How can I help out? I am not a graphic designer, but maybe I can look for ResearchGate SVG on the Internet. I am not sure if I will be able to find one that requires no attribution.

2) How do I apply the Tik-Tok icon you linked? Do I have to manually edit the files on my server as signified in the diff file? Is there a way to automatically do so?

Best,
Mislav

#5 in reply to: ↑ 4 @audrasjb
6 weeks ago

  • Milestone changed from Awaiting Review to 5.5

Replying to mislavjuric:

1) How can I help out? I am not a graphic designer, but maybe I can look for ResearchGate SVG on the Internet. I am not sure if I will be able to find one that requires no attribution.

As per previous comments, we should probably first include ResearchGate as an Embed provider so it will need another ticket. We already did that for TikTok in WP 5.3/5.4. For reference, see ticket #49083. I think ResearchGate should follow the same path.

2) How do I apply the Tik-Tok icon you linked? Do I have to manually edit the files on my server as signified in the diff file? Is there a way to automatically do so?

This diff file needs to be applied to trunk using Git or SVN versioning system. I think it can be implemented in WordPress 5.5, planned for August.

But if you want to implement this patch on your website, I shared above the fixed PHP file. It's located in wp-content/twentytwenty/classes You can replace the existing file with this one if you want.

Cheers,
Jb

#6 follow-up: @poena
6 weeks ago

The source, license information, and copyright information of the icon (-if not already included), must be added to the readme file.

#7 in reply to: ↑ 6 @audrasjb
6 weeks ago

  • Keywords needs-refresh added; commit removed

Replying to poena:

The source, license information, and copyright information of the icon (-if not already included), must be added to the readme file.

Oh. Right, Flaticon is not used in Twenty Twenty yet… Let's add a line in the readme file.

@audrasjb
6 weeks ago

Bundled Themes: Twenty Twenty: Add TikTok to Social Menu

#8 @audrasjb
6 weeks ago

  • Keywords commit added; needs-refresh removed

#9 @ianbelanger
6 weeks ago

  • Owner changed from audrasjb to ianbelanger
  • Status changed from accepted to assigned

Reviewing for commit.

#10 @ianbelanger
6 weeks ago

@audrasjb I just tested your patch and the TikTok icon is not showing up in my menu. Can you confirm that it still works for you? Thanks

#11 @audrasjb
6 weeks ago

Yep it works on my side. Maybe a caching issue?

#12 @audrasjb
6 weeks ago

Did you use a tiktok.com profile URL?

#13 @ianbelanger
6 weeks ago

Yup, I used a tiktok.com profile url and cleared my cache. Same thing in an incognito window, no icon.

@poena or @mislavjuric could you test the patch and report back?

Thanks

#14 @audrasjb
6 weeks ago

  • Keywords commit removed

Ah sorry @ianbelanger I messed up my last patch.
The first one works fine, I'm going to generate a new one, sorry for the inconvenience :(

@audrasjb
6 weeks ago

Bundled Themes: Twenty Twenty: Add TikTok to Social Menu

#15 @audrasjb
6 weeks ago

  • Keywords commit added

Should be good now @ianbelanger, sorry for the mistake 🙂

#16 @ianbelanger
6 weeks ago

No worries @audrasjb, that patch works perfectly, committing now.

#17 @ianbelanger
6 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 47589:

Bundled Themes: Twenty Twenty add TikTok to the social icon menu.

This adds TikTok as an option in the social icon menu.

Props mislavjuric, poena, audrasjb.
Fixes #49893.

#18 @ianbelanger
6 weeks ago

  • Keywords fixed-major added
  • Milestone changed from 5.5 to 5.4.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport.

#19 @poena
5 weeks ago

This license is not compatible with GPL. Only version 4 of CC-BY is compatible.
If this is the icon that is used in Gutenberg, then that needs to be replaced as well.

Flaticon Icons
License: Creative Commons BY 3.0, http://creativecommons.org/licenses/by/3.0/
Source: Made by Freepik (https://www.flaticon.com/authors/freepik) for Flaticon (http://www.flaticon.com)
Used for TikTok social icon.

Please always refer to the official list of compatible licenses:
https://www.gnu.org/licenses/license-list.html#ccby

#20 @audrasjb
2 weeks ago

  • Keywords needs-patch added; has-patch commit fixed-major removed
  • Milestone changed from 5.4.2 to 5.5

You are right @poena
I asked someone in my team to design a tiktok icon which can be used in GPLv2. They'll upload the icon soon :)

#21 @Emlebrun
2 weeks ago

Hello,
I made the Icon (SVG) by myself and under GPL v2 license.

@Emlebrun
2 weeks ago

Logo TikTok Svg

@audrasjb
2 weeks ago

Bundled Themes: Replace TikTok icon with GPLv2 compatible SVG

@audrasjb
2 weeks ago

Bundled Themes: Replace TikTok icon with GPLv2 compatible SVG (screenshot of the new icon)

#22 @audrasjb
2 weeks ago

  • Keywords has-patch added; needs-patch removed
  • Owner changed from ianbelanger to audrasjb
  • Status changed from reopened to assigned

Thanks @Emlebrun !

I tested the proposed icon and it looks great (see screenshot above).

In 49893.3.diff, I replaced the previously introduced TikTok icon with the new GPLv2 compatible SVG icon.
I also updated the readme file accordingly.

This ticket is now slated to milestone 5.5.
Cheers,
Jb

Last edited 2 weeks ago by audrasjb (previous) (diff)

#23 @audrasjb
2 weeks ago

  • Keywords commit added

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


2 weeks ago

#25 @ianbelanger
2 weeks ago

  • Owner changed from audrasjb to ianbelanger
  • Status changed from assigned to reviewing

#26 @ianbelanger
2 weeks ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47796:

Bundled Themes: Twenty Twenty add GPLv2 compatible TikTok icon to the social icon menu.

This adds a GPLv2 compatible TikTok icon to replace the non-compatible TikTok icon and update the readme.txt file. Updates previous commit which used a non-compatible TikTok icon [47589]

Props poena, audrasjb, Emlebrun.
Fixes #49893.

#27 @audrasjb
13 days ago

  • Keywords fixed-major added
  • Milestone changed from 5.5 to 5.4.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for proper backporting into branch 5.4.
This change was already shipped in Twenty Twenty 1.3.

#28 @whyisjake
9 days ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 47822:

Bundled Themes: Twenty Twenty add GPLv2 compatible TikTok icon to the social icon menu.

This adds a GPLv2 compatible TikTok icon to replace the non-compatible TikTok icon and update the readme.txt file. Updates previous commit which used a non-compatible TikTok icon [47589]

This commit brings the changes from [47796] to the 5.4 branch.

Props poena, audrasjb, Emlebrun.
Fixes #49893.

Note: See TracTickets for help on using tickets.