TwentyTwenty: TikTok and ResearchGate Social Icons

[mislavjuric]

Hello guys,

It seems that Twenty Twenty doesn’t have icons for ResearchGate and TikTok social media. I have the profiles on those social networks linked up on my website and would like to have icons of those two social networks displayed as well.

Could someone add these?

Thank you in advance!

[audrasjb]

Bundled Themes: Twenty Twenty: Add TikTok to Social Menu

[audrasjb]

Bundled Themes: Twenty Twenty: Add TikTok to Social Menu

[audrasjb]

Hi @mislavjuric, welcome to WordPress Core Trac and thank you for opening this ticket,

49893.diff implements TikTok icon to Twenty Twenty’s Social Menu.

Unfortunately, I can't find a good SVG markup for ResearchGate logo.
@mislavjuric could you help ton find this SVG asset, please?

Cheers,
Jb

[poena]

This is just my opinion but I feel strongly that the icons in the default themes should be consistent between the themes but also consistent with the block editor.

[audrasjb]

@poena In my opinion, you're right.
Let's wait for ResearchGate Embed to be implemented in the Editor.

Then, let's add commit workflow keyword for the TikTok part only (as it was introduced in WordPress Embeds in WP 5.4) :)

[mislavjuric]

Replying to audrasjb:

Hi @mislavjuric, welcome to WordPress Core Trac and thank you for opening this ticket,

49893.diff implements TikTok icon to Twenty Twenty’s Social Menu.

Unfortunately, I can't find a good SVG markup for ResearchGate logo.
@mislavjuric could you help ton find this SVG asset, please?

Cheers,
Jb

Hey, I've got two questions:

1) How can I help out? I am not a graphic designer, but maybe I can look for ResearchGate SVG on the Internet. I am not sure if I will be able to find one that requires no attribution.

2) How do I apply the Tik-Tok icon you linked? Do I have to manually edit the files on my server as signified in the diff file? Is there a way to automatically do so?

Best,
Mislav

[audrasjb]

Replying to mislavjuric:

1) How can I help out? I am not a graphic designer, but maybe I can look for ResearchGate SVG on the Internet. I am not sure if I will be able to find one that requires no attribution.

As per previous comments, we should probably first include ResearchGate as an Embed provider so it will need another ticket. We already did that for TikTok in WP 5.3/5.4. For reference, see ticket #49083. I think ResearchGate should follow the same path.

2) How do I apply the Tik-Tok icon you linked? Do I have to manually edit the files on my server as signified in the diff file? Is there a way to automatically do so?

This diff file needs to be applied to trunk using Git or SVN versioning system. I think it can be implemented in WordPress 5.5, planned for August.

But if you want to implement this patch on your website, I shared above the fixed PHP file. It's located in wp-content/twentytwenty/classes You can replace the existing file with this one if you want.

Cheers,
Jb

[poena]

The source, license information, and copyright information of the icon (-if not already included), must be added to the readme file.

[audrasjb]

Replying to poena:

The source, license information, and copyright information of the icon (-if not already included), must be added to the readme file.

Oh. Right, Flaticon is not used in Twenty Twenty yet… Let's add a line in the readme file.

[audrasjb]

Bundled Themes: Twenty Twenty: Add TikTok to Social Menu

[ianbelanger]

Reviewing for commit.

[ianbelanger]

@audrasjb I just tested your patch and the TikTok icon is not showing up in my menu. Can you confirm that it still works for you? Thanks

[audrasjb]

Yep it works on my side. Maybe a caching issue?

[audrasjb]

Did you use a tiktok.com profile URL?

[ianbelanger]

Yup, I used a tiktok.com profile url and cleared my cache. Same thing in an incognito window, no icon.

@poena or @mislavjuric could you test the patch and report back?

Thanks

[audrasjb]

Ah sorry @ianbelanger I messed up my last patch.
The first one works fine, I'm going to generate a new one, sorry for the inconvenience :(

[audrasjb]

Bundled Themes: Twenty Twenty: Add TikTok to Social Menu

[audrasjb]

Should be good now @ianbelanger, sorry for the mistake 🙂

[ianbelanger]

No worries @audrasjb, that patch works perfectly, committing now.

[ianbelanger]

In 47589:

Bundled Themes: Twenty Twenty add TikTok to the social icon menu.

This adds TikTok as an option in the social icon menu.

Props mislavjuric, poena, audrasjb.
Fixes #49893.

[ianbelanger]

Reopening for backport.

[poena]

This license is not compatible with GPL. Only version 4 of CC-BY is compatible.
If this is the icon that is used in Gutenberg, then that needs to be replaced as well.

Flaticon Icons
License: Creative Commons BY 3.0, http://creativecommons.org/licenses/by/3.0/
Source: Made by Freepik (https://www.flaticon.com/authors/freepik) for Flaticon (http://www.flaticon.com)
Used for TikTok social icon.

Please always refer to the official list of compatible licenses:
​https://www.gnu.org/licenses/license-list.html#ccby

[audrasjb]

You are right @poena
I asked someone in my team to design a tiktok icon which can be used in GPLv2. They'll upload the icon soon :)

[Emlebrun]

Hello,
I made the Icon (SVG) by myself and under GPL v2 license.

[Emlebrun]

Logo TikTok Svg

[audrasjb]

Bundled Themes: Replace TikTok icon with GPLv2 compatible SVG

[audrasjb]

Bundled Themes: Replace TikTok icon with GPLv2 compatible SVG (screenshot of the new icon)

[audrasjb]

Thanks @Emlebrun !

I tested the proposed icon and it looks great (see screenshot above).

In 49893.3.diff, I replaced the previously introduced TikTok icon with the new GPLv2 compatible SVG icon.
I also updated the readme file accordingly.

This ticket is now slated to milestone 5.5.
Cheers,
Jb

[ianbelanger]

In 47796:

Bundled Themes: Twenty Twenty add GPLv2 compatible TikTok icon to the social icon menu.

This adds a GPLv2 compatible TikTok icon to replace the non-compatible TikTok icon and update the readme.txt file. Updates previous commit which used a non-compatible TikTok icon [47589]

Props poena, audrasjb, Emlebrun.
Fixes #49893.

[audrasjb]

Reopening for proper backporting into branch 5.4.
This change was already shipped in Twenty Twenty 1.3.

[whyisjake]

In 47822:

Bundled Themes: Twenty Twenty add GPLv2 compatible TikTok icon to the social icon menu.

This adds a GPLv2 compatible TikTok icon to replace the non-compatible TikTok icon and update the readme.txt file. Updates previous commit which used a non-compatible TikTok icon [47589]

This commit brings the changes from [47796] to the 5.4 branch.

Props poena, audrasjb, Emlebrun.
Fixes #49893.