WordPress.org

Make WordPress Core

Opened 3 months ago

Last modified 5 weeks ago

#49923 new defect (bug)

Change "Critical Issue" to "Recommendation"

Reported by: La Geek Owned by:
Milestone: Awaiting Review Priority: normal
Severity: critical Version: 5.4
Component: Site Health Keywords:
Focuses: Cc:

Description

Why do you call this a critical Issue? (see screenshot please) I know, this is not new, but since 5.4 and the site health dashboard widget my clients get panic.

Someone who knows how to write and set the WP_AUTO_UPDATE_CORE constant usually also knows, what this does. And it's a very conscious decision to disable the automatic updates and do the manual updates instead.

And if this would be really critical, why all these constants and filters do exist?

This should be changed to a hint = "Background updates are disabled" or a recommendation = "To receive background updates, enable ..."

But never ever this should be a critical issue.

https://p216.p3.n0.cdn.getcloudapp.com/items/jkuloA5w/Image%202020-04-16%20at%203.25.01%20PM.png

Attachments (1)

critical_issue.jpg (49.4 KB) - added by La Geek 3 months ago.

Download all attachments as: .zip

Change History (4)

#1 follow-up: @Clorith
2 months ago

Hmm, although I would argue that you could filter out the tests if you're familiar with what you are doing... I do have a different thought here though.

We could check if minor updates are still allowed to run automatically, if they can, the severity could be lowered to a recommendation, but having automatic security updates completely disabled should still give a critical error in my opinion, as unknowing users might have changed values based on recommendations without knowing what they do, while those that do know what they do and are aware may ignore the output of this check (or use one of the plugins that filters it away).

Thoughts?

#2 in reply to: ↑ 1 @La Geek
2 months ago

Replying to Clorith:

Hmm, although I would argue that you could filter out the tests if you're familiar with what you are doing... I do have a different thought here though.

Sure, for upcoming client websites. But past client websites where you don't have any access anymore ... most of my clients want to update and manage their websites themselves ¯\_(ツ)_/¯ but get panic with this new site health widget.

We could check if minor updates are still allowed to run automatically, if they can, the severity could be lowered to a recommendation, but having automatic security updates completely disabled should still give a critical error in my opinion, as unknowing users might have changed values based on recommendations without knowing what they do, while those that do know what they do and are aware may ignore the output of this check (or use one of the plugins that filters it away).

Thoughts?

If minor updates are allowed, you don't need any hint at all (or do I mistunderstand?)

A recommendation, when automatic updates are filtered out, is enough (imo). The hint text should be changed and explain more.

And it is no error. The filters and constants are valid.

#3 @Presskopp
5 weeks ago

related #50118 (if not duplicate)

Note: See TracTickets for help on using tickets.