Opened 5 years ago
Closed 5 years ago
#49967 closed defect (bug) (fixed)
Remove never-used commented out code in nav-menus.php update add menu block
Reported by: | garrett-eclipse | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 5.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Menus | Keywords: | has-patch commit |
Focuses: | coding-standards | Cc: |
Description (last modified by )
Hello,
While working on #44286 I noticed there was a piece of commented out code;
<?php // $messages[] = '<div id="message" class="updated"><p>' . sprintf( __( '<strong>%s</strong> has been created.' ), $nav_menu_selected_title ) . '</p></div>';
Looking into it the piece of code was only used in a patch that never saw the light of day, instead in changeset [23810] for ticket #23770 it was added already commented out.
This code isn't needed as directly after it a wp_redirect is run so the message handler never executes in this case.
Attachments (1)
Change History (5)
Note: See
TracTickets for help on using
tickets.
Patch to remove unneeded commented out code.