Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#49974 closed defect (bug) (fixed)

Let's backport some Gutenberg fixes to WordPress 5.4.1

Reported by: whyisjake's profile whyisjake Owned by: whyisjake's profile whyisjake
Milestone: 5.4.1 Priority: highest omg bbq
Severity: normal Version: 5.4
Component: Editor Keywords: dev-reviewed has-patch
Focuses: Cc:

Attachments (3)

49974.diff (212.6 KB) - added by whyisjake 4 years ago.
49974.2.diff (19.3 KB) - added by whyisjake 4 years ago.
49974-sl-changes.diff (37.8 KB) - added by whyisjake 4 years ago.

Download all attachments as: .zip

Change History (18)

#1 @whyisjake
4 years ago

Open pull request to cherry-pick the commits over: https://github.com/WordPress/gutenberg/pull/21800

Last edited 4 years ago by whyisjake (previous) (diff)

This ticket was mentioned in Slack in #core by whyisjake. View the logs.


4 years ago

#3 @whyisjake
4 years ago

  • Version set to 5.4

Packages to update:

  • @wordpress/base-styles@1.4.1
  • @wordpress/block-directory@1.5.8
  • @wordpress/block-editor@3.7.8
  • @wordpress/block-library@2.14.8
  • @wordpress/e2e-tests@1.12.9
  • @wordpress/edit-post@3.13.10
  • @wordpress/edit-site@1.3.7
  • @wordpress/editor@9.12.8
  • @wordpress/format-library@1.14.8
  • @wordpress/scripts@7.1.4

@whyisjake
4 years ago

@whyisjake
4 years ago

This ticket was mentioned in PR #235 on WordPress/wordpress-develop by whyisjake.


4 years ago
#5

#6 @whyisjake
4 years ago

Tests are passing, I'll get a review from @jorgefilipecosta and merge for the release tomorrow.

#7 @whyisjake
4 years ago

Props to be sure to include here:

youknowriad, toro_unit, ellatrix, roo2, noahtallen, arnaudbroes, chrisvanpatten, apeatling, mcsf, jorgefilipecosta, talldanwp, aduth, noisysocks

#8 @gziolo
4 years ago

Code changes look good, I double-checked all version bumps for packages. I'll leave the testing part to @jorgefilipecosta :)

#9 @jorgefilipecosta
4 years ago

Hi @whyisjake, the file src/wp-includes/assets/script-loader-packages.php is not updated. After applying the patch, you submitted and executing "npm run build" the file should be automatically updated. An example of the changes that will happen can be checked at https://github.com/WordPress/wordpress-develop/commit/e858ea70583128fabef7afd0762ba6dfbca6fe93.

#10 @whyisjake
4 years ago

@jorgefilipecosta after npm run build, or the subtask of grunt build:webpack I'm seeing the changes showing up in that file. Are you seeing those changes in your local testing?

#11 @jorgefilipecosta
4 years ago

Hi @whyisjake, sorry I did not explain correctly. The file is automatically updated locally after executing "npm run build", the only issue was that the file changes were not included in the patch. I think the changes should be included in the patch or during the commit.

#12 @whyisjake
4 years ago

The patch above is from @jorgefilipecosta, looks good to me.

#13 @whyisjake
4 years ago

  • Keywords has-patch added; needs-patch removed

#14 @jorgefilipecosta
4 years ago

  • Keywords dev-reviewed added

#15 @whyisjake
4 years ago

  • Owner set to whyisjake
  • Resolution set to fixed
  • Status changed from assigned to closed

In 47619:

Block Editor: Update WordPress Packages for WordPress 5.4.1

The following packages were updated:

@wordpress/block-directory 1.5.7 ➡️ 1.5.8
@wordpress/block-editor 3.7.7 ➡️ 3.7.8
@wordpress/block-library 2.14.7 ➡️ 2.14.8
@wordpress/edit-post 3.13.9 ➡️ 3.13.10
@wordpress/editor 9.12.7 ➡️ 9.12.8
@wordpress/format-library 1.14.7 ➡️ 1.14.8

Props whyisjake, youknowriad, toro_unit, ellatrix, roo2, noahtallen, arnaudbroes, chrisvanpatten, apeatling, mcsf, jorgefilipecosta, talldanwp, aduth, noisysocks.
Fixes #49974.

Note: See TracTickets for help on using tickets.