Opened 4 years ago
Closed 4 years ago
#49974 closed defect (bug) (fixed)
Let's backport some Gutenberg fixes to WordPress 5.4.1
Reported by: | whyisjake | Owned by: | whyisjake |
---|---|---|---|
Milestone: | 5.4.1 | Priority: | highest omg bbq |
Severity: | normal | Version: | 5.4 |
Component: | Editor | Keywords: | dev-reviewed has-patch |
Focuses: | Cc: |
Description
Looks like this is the main block: https://github.com/WordPress/gutenberg/pulls?q=is%3Apr+sort%3Aupdated-desc+label%3A%22Backport+to+WP+Core%22+is%3Aclosed
Attachments (3)
Change History (18)
#1
@
4 years ago
This ticket was mentioned in Slack in #core by whyisjake. View the logs.
4 years ago
#3
@
4 years ago
- Version set to 5.4
Packages to update:
- @wordpress/base-styles@1.4.1
- @wordpress/block-directory@1.5.8
- @wordpress/block-editor@3.7.8
- @wordpress/block-library@2.14.8
- @wordpress/e2e-tests@1.12.9
- @wordpress/edit-post@3.13.10
- @wordpress/edit-site@1.3.7
- @wordpress/editor@9.12.8
- @wordpress/format-library@1.14.8
- @wordpress/scripts@7.1.4
#4
@
4 years ago
Github PR here to run tests: https://github.com/WordPress/wordpress-develop/pull/235
This ticket was mentioned in PR #235 on WordPress/wordpress-develop by whyisjake.
4 years ago
#5
Packages updates related to https://github.com/WordPress/gutenberg/pull/21800 for WordPress 5.4.1.
#6
@
4 years ago
Tests are passing, I'll get a review from @jorgefilipecosta and merge for the release tomorrow.
#7
@
4 years ago
Props to be sure to include here:
youknowriad, toro_unit, ellatrix, roo2, noahtallen, arnaudbroes, chrisvanpatten, apeatling, mcsf, jorgefilipecosta, talldanwp, aduth, noisysocks
#8
@
4 years ago
Code changes look good, I double-checked all version bumps for packages. I'll leave the testing part to @jorgefilipecosta :)
#9
@
4 years ago
Hi @whyisjake, the file src/wp-includes/assets/script-loader-packages.php is not updated. After applying the patch, you submitted and executing "npm run build" the file should be automatically updated. An example of the changes that will happen can be checked at https://github.com/WordPress/wordpress-develop/commit/e858ea70583128fabef7afd0762ba6dfbca6fe93.
#10
@
4 years ago
@jorgefilipecosta after npm run build
, or the subtask of grunt build:webpack
I'm seeing the changes showing up in that file. Are you seeing those changes in your local testing?
Open pull request to cherry-pick the commits over: https://github.com/WordPress/gutenberg/pull/21793