WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#49986 closed enhancement (fixed)

Twenty Twenty: Remove unnecessary $css_dependencies variable in twentytwenty_block_editor_styles()

Reported by: ocean90's profile ocean90 Owned by: ianbelanger's profile ianbelanger
Milestone: 5.5 Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: good-first-bug has-patch commit
Focuses: Cc:

Description

twentytwenty_block_editor_styles() defines $css_dependencies with an empty array which is only used in the wp_enqueue_style() call. There's no need for an extra variable here.

This was probably copied from twentytwenty_register_styles() at some point before ​Font Awesome was replaced.

Attachments (1)

49986.diff​ (870 bytes) - added by Dency 6 years ago.

Download all attachments as: .zip

Change History (5)

@Dency
6 years ago

#2 @ianbelanger
6 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

#3 @ianbelanger
6 years ago

  • Keywords commit added; needs-testing removed
  • Milestone changed from Future Release to 5.5
  • Owner set to ianbelanger
  • Status changed from new to reviewing

#4 @ianbelanger
6 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47618:

Bundled Themes: Twenty Twenty remove unnecessary $css_dependencies variable in twentytwenty_block_editor_styles().

Removes the unnecessary $css_dependencies variable in twentytwenty_block_editor_styles().

Props ocean90, Dency.
Fixes #49986.

Note: See TracTickets for help on using tickets.