Context Navigation

← Previous Ticket
Next Ticket →

#50009 closed task (blessed) (wontfix)

class-wp-block-parser.php shouldn't be excluded from coding standards

Reported by:	johnbillion	Owned by:
Priority:	normal	Milestone:
Component:	Editor	Version:	5.0
Severity:	normal	Keywords:
Cc:		Focuses:	coding-standards

Description

The PHPCS config file excludes class-wp-block-parser.php from coding standards checks because the file is imported from Gutenberg but does not adhere to core's coding standards.

Gutenberg issue for fixing the file: https://github.com/WordPress/gutenberg/issues/21891

Once this issue is resolved, the coding standards exclusion should be removed from core.

Change History (6)

#1 @noisysocks
6 years ago

Milestone Awaiting Review → Future Release
Type enhancement → task (blessed)

This ticket was mentioned in Slack in #core by peterwilsoncc. View the logs.

5 years ago

#3 @SergeyBiryukov
3 years ago

Related: #57832

#4 @johnbillion
3 years ago

Milestone Future Release
Resolution → wontfix
Status new → closed

#5 @SergeyBiryukov
3 years ago

I believe this was effectively resolved in [56048] / #57832. The file is no longer ignored wholesale, only a few select sniffs for non-snake-case variables and properties.

#6 @johnbillion
3 years ago

Yep that's what I determined too.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#50009 closed task (blessed) (wontfix)

class-wp-block-parser.php shouldn't be excluded from coding standards

Description

Change History (6)

#1 @noisysocks 6 years ago

This ticket was mentioned in ​Slack in #core by peterwilsoncc. ​View the logs. 5 years ago

#3 @SergeyBiryukov 3 years ago

#4 @johnbillion 3 years ago

#5 @SergeyBiryukov 3 years ago

#6 @johnbillion 3 years ago