WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 16 months ago

Last modified 16 months ago

#50009 closed task (blessed) (wontfix)

class-wp-block-parser.php shouldn't be excluded from coding standards

Reported by: johnbillion's profile johnbillion Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.0
Component: Editor Keywords:
Focuses: coding-standards Cc:

Description

The PHPCS config file excludes class-wp-block-parser.php from coding standards checks because the file is imported from Gutenberg but does not adhere to core's coding standards.

Gutenberg issue for fixing the file: ​https://github.com/WordPress/gutenberg/issues/21891

Once this issue is resolved, the coding standards exclusion should be removed from core.

Change History (6)

#1 @noisysocks
4 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Type changed from enhancement to task (blessed)

This ticket was mentioned in ​Slack in #core by peterwilsoncc. ​View the logs.
4 years ago

#4 @johnbillion
16 months ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

#5 @SergeyBiryukov
16 months ago

I believe this was effectively resolved in [56048] / #57832. The file is no longer ignored wholesale, only a few select sniffs for non-snake-case variables and properties.

#6 @johnbillion
16 months ago

Yep that's what I determined too.

Note: See TracTickets for help on using tickets.