wp-includes/blocks shouldn't be excluded from coding standards

[johnbillion]

The wp-incudes/blocks directory is excluded from coding standards. This is presumably because the files are imported from Gutenberg, but there's no reason these files shouldn't adhere to core's coding standards.

Needs some investigation into why the directory is excluded, whether the files need updating in Gutenberg to adhere to core coding standards, and corresponding tickets on the Gutenberg repo as necessary.

[lopo]

I tried to enable CS checks on the folder, and we get just four sets of errors like:

 1 | ERROR | [x] When a multi-item array uses associative keys, each value should start on a new line.
   |       |     (WordPress.Arrays.ArrayDeclarationSpacing.AssociativeArrayFound)
 1 | ERROR | [x] File must end with a newline character (Generic.Files.EndFileNewline.NotFound)

on navigation/view.asset.php, navigation/view.min.asset.php, file/view.asset.php and file/view.min.asset.php because they all like this:

<?php return array('dependencies' => array(), 'version' => '3776ea67846b3bb10fe8f7cdd486b0ba');

Obviously they're trivial problems but as far as I know those files are autogenerated, so with my limited knowledge of Gutenberg I'm not sure what can be done about them.

Exclude any asset file from the blocs directory since they are auto-generated.

Trac ticket: https://core.trac.wordpress.org/ticket/50010

[Rahe]

Hello,

I've added a PR for this since, as said, the PHP files are auto-generated.
But maybe there will never be any PHP files into theses directories ?

[adamsilverstein]

@johnbillion what do you think of the proposed solution that changes the exclusion to only the auto-generated files, not the entire folder? Otherwise the fix probably belongs in Gutenberg, right?

[johnbillion]

Sounds good to me.

[johnbillion]

In 56392:

Editor: Only exclude auto-generated block files from coding standards checks.

Prior to this change, all block files were excluded from coding standards checks, but there's no reason these files shouldn't adhere to core's coding standards.

Props lopo, Rahe, adamsilverstein 

Fixes #50010

https://core.trac.wordpress.org/changeset/56392