WordPress.org

Make WordPress Core

Opened 4 weeks ago

Last modified 3 weeks ago

#50029 reviewing defect (bug)

Twenty Fifteen: Bulleted list block appears too far to the left in the editor.

Reported by: kjellr Owned by: ianbelanger
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-screenshots
Focuses: css Cc:

Description

Twenty Fifteen contains some unnecessary margin rules for bulleted lists in the editor, that result in the list block being pushed far off to the left on large screens:

.edit-post-visual-editor ul:not(.wp-block-gallery),
.editor-block-list__block ul:not(.wp-block-gallery),
.block-library-list ul,
.edit-post-visual-editor ol,
.editor-block-list__block ol,
.block-library-list ol {
	margin: 0 0 1.6em 1.3333em;
	...
}

This issue is visible using WordPress 5.4, but only with the Gutenberg plugin (v7.9.1) active. These margins can be removed, and the block can inherit the default Gutenberg margins to correct the problem. This causes no issues on 5.4 even the the plugin is deactivated.


Before:

http://cldup.com/jRR8QINF8w.png

After:

http://cldup.com/ED7lIA13BL.png

Attachments (3)

50029.diff (445 bytes) - added by kjellr 4 weeks ago.
50029-gb-plugin-active.png (40.3 KB) - added by ianbelanger 4 weeks ago.
Gutenberg active
50029-gb-plugin-not-active.png (44.1 KB) - added by ianbelanger 4 weeks ago.
Gutenberg inactive

Download all attachments as: .zip

Change History (6)

@kjellr
4 weeks ago

@ianbelanger
4 weeks ago

Gutenberg active

@ianbelanger
4 weeks ago

Gutenberg inactive

#1 @ianbelanger
4 weeks ago

  • Focuses css added
  • Keywords reporter-feedback has-screenshots added

Hey @kjellr, I can't recreate the issue using GB V7.9.1. See my screenshots above. You'll notice that the paragraph and list blocks are both aligned the same way. With GB active, the content width is no longer respected, as it is with GB inactive.

#2 @kjellr
3 weeks ago

Thanks for testing, @ianbelanger. That’s odd! What browser are you using there? I just re-tested with Gutenberg v8.0.0 now that it’s been released, and I’m still seeing the issue persist:

http://cldup.com/zf-J80Snhp.png

The patch above still seems to fix it. Would you mind re-testing with 8.0.0?

#3 @ianbelanger
3 weeks ago

  • Keywords reporter-feedback removed
  • Owner set to ianbelanger
  • Status changed from new to reviewing

Hey @kjellr,

I just tested it again with GB 8.0.0 and all seems to be working as you reported. I see the bug and after applying your patch, the issue is fixed. I'm going to test a little more and if all goes well I'll get this committed.

Thanks for your work on this!!

Note: See TracTickets for help on using tickets.