WordPress.org

Make WordPress Core

Opened 3 months ago

Last modified 5 weeks ago

#50042 assigned task (blessed)

Update Docker environment to allow specific versions of PHPUnit to be loaded

Reported by: desrosj Owned by: desrosj
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

To help with tackling #48301, new PHPUnit images now being created for all combinations of supported PHPUnit versions on each PHP version.

To make loading specific versions of PHPUnit possible, Core's Docker file needs to be updated.

See the GitHub PR and PHPUnit version compatibility page in the handbook.

Related: #47767.

Attachments (1)

50042.diff (1.1 KB) - added by desrosj 3 months ago.

Download all attachments as: .zip

Change History (5)

@desrosj
3 months ago

#1 @desrosj
3 months ago

Besides using this and changing the version of PHPUnit locally in the .env file, Travis jobs can be updated as such:

- env: LOCAL_PHP=7.0-fpm LOCAL_PHPUNIT=6-php-7.0-fpm WP_TRAVISCI=test:php

For older branches (4.7-5.0), PHPUnit 6 is required for PHP 7.0. This would ensure the required version is installed.

#2 @desrosj
3 months ago

  • Owner set to desrosj
  • Status changed from new to assigned

#3 @desrosj
3 months ago

  • Keywords 2nd-opinion added

This implementation has one issue though.

Currently, the LOCAL_PHP value is used to load PHPUnit. However, now that it has it's own independent variable, committing 50042.diff would cause all PHP 5.6 jobs using trunk would fail unless LOCAL_PHPUNIT is set correctly because PHPUnit 5 is required. In 50042.diff, latest would be used, which would load 7.

#4 @desrosj
5 weeks ago

  • Milestone changed from 5.5 to Future Release

I'm going to punt this for now with beta 1 tomorrow. It's a build tooling ticket, so it can be committed later if someone has a chance to work on it.

Note: See TracTickets for help on using tickets.