WordPress.org

Make WordPress Core

Opened 18 months ago

Last modified 15 months ago

#50052 closed enhancement

Plugins & Themes Auto-Updates πŸ€– β€” at Version 14

Reported by: whyisjake Owned by: whyisjake
Milestone: 5.5 Priority: normal
Severity: normal Version: 5.5
Component: Security Keywords: needs-testing needs-design-feedback needs-docs has-patch has-dev-note
Focuses: ui, administration Cc:

Description (last modified by audrasjb)

WordPress Auto-updates πŸ€–

With the maturity of the ​WordPress AutoUpdates plugin, let's get this merged to core for WordPress 5.5.

Recent Changes

0.7.0 🦒

May 6, 2020

0.6.0 πŸ¦‹

April 22, 2020

  • Add Ajax to Plugin and Themes Screen - ​#61
  • Accessibility: Communicate AJAX enabling/disabling changes to screen readers - ​#85
  • Add Better Handling to Ajax Errors - ​#90
  • Prevent CSS from being enqueued on sub-site plugins & themes screens in multisite - ​#91

0.5.1 πŸ¦’

April 16, 2020

  • Add the plugin version when enqueueing styles, for cache busting - ​#79

0.5.0 🦚

April 15, 2020

  • Replace Disable strings with Disable auto-updates - ​#78
  • Update confirmation message wording - ​#77
  • Remove Automatic Updates column from the Network Admin > Sites > Edit > Themes screen - ​#76
  • Replace "Enable" string with "Enable auto-updates" - ​#75
  • Remove dashicons from the UI - ​#74
  • Fix documentation and comment standards - ​#73
  • Remove green and red colors on texts and links - ​#70
  • Don't display the Enable/Disable link in the Theme Details modal on a subsite in multisite - ​#68
  • Documentation: Improve DocBlocks - ​#62
  • I18n - Merge with similar string - ​#60
  • Add filters and constant to allow developers to disable plugins and themes autoupdate email notifications - ​#57
  • Switch disable link to red on Multisite Themes Screen - ​#54
  • Wrong kick off year in readme.txt - ​#42

0.4.1 🍺

April 2, 2020

  • Network > Sites > Edit > Themes screen doesn’t have the Autoupdates column - ​#50

0.4.0 🌹

March 30, 2020

This release brings full support for Themes auto-updates.

It also changes the plugin structure to allow self deactivation when the feature gets merged into WordPress Core.

Please note: the development repository was also migrated from @audrasjb’s personal GitHub account to WordPress.org official GitHub account.

Other changes:

  • Change plugin structure to ensure it can self-deactivate when the feature is merged into Core - ​#37
  • Handle both themes and plugins email notifications - ​#36
  • i18n: Merge similar translation strings - ​#35

Add and populate Automatic updates column, add and handle enable/disable auto-updates bulk actions to the multisite themes list * table - ​#33

  • Avoid duplicate Updating… dialog - ​#32

Change History (15)

#1 @whyisjake
18 months ago

  • Keywords needs-patch needs-testing needs-design-feedback needs-codex needs-docs added
  • Milestone changed from Awaiting Review to 5.5
  • Type changed from defect (bug) to enhancement
  • Version set to trunk

#2 @audrasjb
18 months ago

  • Keywords needs-dev-note added

Related: #48850, #49199

#3 @whyisjake
18 months ago

  • Focuses ui administration added
  • Keywords needs-dev-note removed

#4 @whyisjake
18 months ago

  • Owner set to whyisjake
  • Status changed from new to accepted

#5 @whyisjake
18 months ago

  • Component changed from General to Security

#6 follow-ups: @afercia
18 months ago

One of the criteria to merge features-as-plugins into core is that the new code meets the WordPress coding standards.

​https://make.wordpress.org/core/handbook/about/release-cycle/features-as-plugins/#feature-plugin-merge-criteria

The code conforms to the WordPress coding standards.

Looking at the latest version of the plugin on GitHub, I see the main JS file needs quite a bit of adjustments to meet the coding standards. See ​https://github.com/WordPress/wp-autoupdates/blob/3c7032b7310569e830a9dadcab0fdb06cacba23e/js/wp-autoupdates.js

#7 in reply to: ↑ 6 @pbiron
18 months ago

Replying to afercia:

Looking at the latest version of the plugin on GitHub, I see the main JS file needs quite a bit of adjustments to meet the coding standards.

Agreed. See ​PR: Fix enabled/disabled count updating for the first step towards that goal.

#8 in reply to: ↑ 6 @pbiron
18 months ago

Replying to afercia:

Looking at the latest version of the plugin on GitHub, I see the main JS file needs quite a bit of adjustments to meet the coding standards.

See ​Simplifies Ajax on both the JS and PHP sides. for a more complete attempt to correct that (which is intended to superseded the other PR I linked to yesterday).

#9 @afercia
18 months ago

@pbiron thanks for clarifying. I was concerned ​the post published on Make 3 days ago claimed the feature plugin as "ready for a core merge", while it appears it's not ready, yet.

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.


18 months ago

#11 @jorbin
18 months ago

Some things worth testing that I remember from Shiny Updates v1 (though not super well, it's been a while):

1) make sure to test plugins who's update contains syntax errors. ​https://plugins.trac.wordpress.org/browser/this-plugin-should-not-be-used exists for this purpose. You can install version 0.1 and then if you update to 0.2, there is a syntax error.

2) There are some JS events that plugins rely on with updates. Should make sure that there are adequate replacements if needed. See #37216 #37512

3) There is alot of logic for ftp/ssh credentials in the existing workflow. Obviously won't matter for autoupdates, but we should ensure it's not broken for manual updates

#12 @pbiron
18 months ago

@jorbin Thank you. Can you also open an issue on the ​Feature Plugin repo so we have your thoughts there as well?

#13 @jorbin
18 months ago

@pbiron no. This isn't an issue with the plugin, this is thoughts of what needs to happen for core which is developed here.

#14 @audrasjb
18 months ago

  • Description modified (diff)

Updated the description of the ticket to add last plugin version.

@pbiron
17 months ago

Note: See TracTickets for help on using tickets.