Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #50105, comment 105


Ignore:
Timestamp:
06/09/2021 01:58:44 AM (8 months ago)
Author:
adamsilverstein
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #50105, comment 105

    initial v1  
    33@johnbillion in the latest patch, i reverted the ajax callback data return shape so that it should match what existed in 5.7, putting the post and page count information in the header as you suggested. Can you confirm this would restore compatibility for Asset Manager Framework?
    44
    5 @joedolson Can you please review the latest patch and give it a test? This biggest change is [https://github.com/WordPress/wordpress-develop/pull/1335/files#diff-a157722401459b9143dd6fd997f65bb0f20f4734d79e24fe2099e9bedee256d2L118-R118 setting the xhr as context] so we have access to the headers. I also wound up changing how the spinner hiding is handled to fix the behavior.
     5@joedolson Can you please review the latest patch and give it a test? This biggest potentially breaking change is [https://github.com/WordPress/wordpress-develop/pull/1335/files#diff-a157722401459b9143dd6fd997f65bb0f20f4734d79e24fe2099e9bedee256d2L118-R118 setting the xhr as context] so we have access to the headers. I also wound up changing how the spinner hiding is handled to fix the behavior.
    66
    77Once we confirm this works well we should commit before beta 2 to get wider testing, especially with potentially affected plugins.