#50148 closed task (blessed) (fixed)
Upgrade Twemoji to 13.0
Reported by: | kraftbj | Owned by: | desrosj |
---|---|---|---|
Milestone: | 5.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Emoji | Keywords: | has-patch has-dev-note |
Focuses: | Cc: |
Description
Twemoji 13.0 has been released: https://github.com/twitter/twemoji/releases/tag/v13.0.0
We can probably use the Smiling Face with Tear ( U+1F972 ) as the canary emoji to determine if the browser's platform supports it https://emojipedia.org/smiling-face-with-tear/
There is at least one changed emoji -- the person with a veil is now gender-neutral with a specific image for woman + veil combination with the old one -- so we should add a new folder on the CDN.
Attachments (3)
Change History (12)
#2
@
5 years ago
- Component changed from External Libraries to Emoji
- Keywords needs-patch added; has-patch removed
Thanks @hareesh-pillai. We'll need to do some more for this. There is a list of emoji in the formatting file that is built (but I don't recall how off the top of my head) and, importantly, need to update the detection script to fire on platforms that don't support that particular version of emoji.
See https://core.trac.wordpress.org/changeset/43377 for examples.
Moving back to Emoji
. Historically, other Twemoji updates have been in the Emoji component.
#4
follow-up:
↓ 5
@
5 years ago
- Keywords has-patch added; needs-patch removed
50148.2.diff also updates the formatting file.
For future refernece, this can be done by running grunt precommit
or, more specifically, grunt precommit:emoji
.
I'll work to coordinate getting the CDN updated when this commit is made.
#5
in reply to:
↑ 4
@
5 years ago
- Keywords needs-patch added; has-patch removed
Replying to desrosj:
For future refernece, this can be done by running
grunt precommit
or, more specifically,grunt precommit:emoji
.
Thanks! I couldn't remember where to look for it.
We still need to update the detection script. Without an update, if a client supported Emoji 12, we possibly wouldn't load and thus not render Emoji 13 characters properly.
I'd like to knock out the detection, but no complaints if anyone grabs it before I get to it.
#6
@
5 years ago
- Keywords has-patch added; needs-patch removed
Updated the loader script to look for the Man Feeding Baby emoji, which is new to Emoji 13.
I confirmed that adding a Man Feeding Baby into the post attempts to pull the emoji from the CDN and the file path matches what the file would be once uploaded ( https://github.com/twitter/twemoji/blob/master/assets/svg/1f468-200d-1f37c.svg ).
#9
@
4 years ago
- Keywords has-dev-note added; commit removed
This was noted in the following dev note: https://make.wordpress.org/core/2020/07/01/external-library-updates-in-wordpress-5-5-call-for-testing/
Update Twemoji from v12.1.3 to v13.0.0