WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 4 months ago

Last modified 4 months ago

#50148 closed task (blessed) (fixed)

Upgrade Twemoji to 13.0

Reported by: kraftbj Owned by: desrosj
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Emoji Keywords: has-patch has-dev-note
Focuses: Cc:

Description

Previously #46805, #44339

Twemoji 13.0 has been released: https://github.com/twitter/twemoji/releases/tag/v13.0.0

We can probably use the Smiling Face with Tear ( U+1F972 ) as the canary emoji to determine if the browser's platform supports it https://emojipedia.org/smiling-face-with-tear/

There is at least one changed emoji -- the person with a veil is now gender-neutral with a specific image for woman + veil combination with the old one -- so we should add a new folder on the CDN.

Attachments (3)

50148.diff (1.7 KB) - added by Hareesh Pillai 5 months ago.
Update Twemoji from v12.1.3 to v13.0.0
50148.2.diff (197.9 KB) - added by desrosj 5 months ago.
50148.3.diff (220.1 KB) - added by kraftbj 5 months ago.
Adds comparison for emoji 13 and updates tests.

Download all attachments as: .zip

Change History (12)

@Hareesh Pillai
5 months ago

Update Twemoji from v12.1.3 to v13.0.0

#1 @Hareesh Pillai
5 months ago

  • Component changed from Emoji to External Libraries
  • Keywords has-patch added

#2 @kraftbj
5 months ago

  • Component changed from External Libraries to Emoji
  • Keywords needs-patch added; has-patch removed

Thanks @hareesh-pillai. We'll need to do some more for this. There is a list of emoji in the formatting file that is built (but I don't recall how off the top of my head) and, importantly, need to update the detection script to fire on platforms that don't support that particular version of emoji.

See https://core.trac.wordpress.org/changeset/43377 for examples.

Moving back to Emoji. Historically, other Twemoji updates have been in the Emoji component.

#3 @desrosj
5 months ago

  • Owner set to desrosj
  • Status changed from new to assigned

@desrosj
5 months ago

#4 follow-up: @desrosj
5 months ago

  • Keywords has-patch added; needs-patch removed

50148.2.diff also updates the formatting file.

For future refernece, this can be done by running grunt precommit or, more specifically, grunt precommit:emoji.

I'll work to coordinate getting the CDN updated when this commit is made.

#5 in reply to: ↑ 4 @kraftbj
5 months ago

  • Keywords needs-patch added; has-patch removed

Replying to desrosj:

For future refernece, this can be done by running grunt precommit or, more specifically, grunt precommit:emoji.

Thanks! I couldn't remember where to look for it.

We still need to update the detection script. Without an update, if a client supported Emoji 12, we possibly wouldn't load and thus not render Emoji 13 characters properly.

I'd like to knock out the detection, but no complaints if anyone grabs it before I get to it.

@kraftbj
5 months ago

Adds comparison for emoji 13 and updates tests.

#6 @kraftbj
5 months ago

  • Keywords has-patch added; needs-patch removed

Updated the loader script to look for the Man Feeding Baby emoji, which is new to Emoji 13.

I confirmed that adding a Man Feeding Baby into the post attempts to pull the emoji from the CDN and the file path matches what the file would be once uploaded ( https://github.com/twitter/twemoji/blob/master/assets/svg/1f468-200d-1f37c.svg ).

#7 @desrosj
5 months ago

  • Keywords commit added

Looks good to me, @kraftbj!

Just linking to a few past tickets for historical reference:

I'll get this in later this week so that everyone using trunk can start including beavers, worms, and tamales in their blog posts!

#8 @desrosj
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 48048:

Emoji: Upgrade Twemoji to version 13.0.0.

🥸

Props kraftbj, desrosj, otto42.
Fixes #50148.

#9 @desrosj
4 months ago

  • Keywords has-dev-note added; commit removed
Note: See TracTickets for help on using tickets.