WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #50159, comment 19


Ignore:
Timestamp:
05/14/2020 03:10:42 PM (17 months ago)
Author:
ocean90
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #50159, comment 19

    initial v1  
    1 Replying to [comment:18 arena]:
    2 > Replying to [comment:16 afragen]:
    3 > > Replying to [comment:14 arena]:
    4 > > > Yes, i have noticed that too. This is a replication of the samples provided by SimplePie.
    5 > > >
    6 > > > This transient has a 12 hours lifetime by default and if deprecated will be erased by appropriate wp-cron job 'delete_expired_transients'.
    7 > > >
    8 > > > I also changed some class names and added 2 new files
    9 > > >
    10 > > > Replying to [comment:12 afragen]:
    11 > > > > You have also changed the transient names.
    12 > > > >
    13 > > > >
    14 > > > > {{{
    15 > > > > 54                              $this->name     = 'feed_' . $filename;
    16 > > > > 55                              $this->mod_name = 'feed_mod_' . $filename;
    17 > > > > }}}
    18 > > > >
    19 > > > > to
    20 > > > >
    21 > > > >
    22 > > > > {{{
    23 > > > >
    24 > > > > 54                      $this->name     = 'feed_' . md5( "$filename:$extension" );
    25 > > > > 55                      $this->mod_name = 'feed_mod_' . md5( "$filename:$extension" );
    26 > > > >
    27 > > > > }}}
    28 > > > >
    29 > > > > This particular item will cause an issue for me.
    30 > > > > https://github.com/afragen/wordpress-beta-tester/blob/develop/src/WPBT/WPBT_Beta_RC.php#L520-L522
    31 > >
    32 > >
    33 > > I noticed the change, my point was why? There is potential incompatibility by changing and there is no need to change it.
    34 >
    35 >  #17 in reply to: ↑ 14 @arena
    36 > 0 seconds ago
    37 >
    38 > On
    39 >
    40 > This particular item will cause an issue for me.
    41 > https://github.com/afragen/wordpress-beta-tester/blob/develop/src/WPBT/WPBT_Beta_RC.php#L520-L522
    42 >
    43 > Are you using SimplePie cache for what looks like a sensitive feed (https://wordpress.org/news/category/development/feed/) ?
    44 
    451I don't understand what you mean by a ''sensitive feed''.
    462