WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#50171 closed defect (bug) (fixed)

HTML Comment references Kubrick

Reported by: ritterml Owned by: SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: normal Version: 5.4
Component: Themes Keywords: has-patch
Focuses: Cc:

Description

Location: https://core.svn.wordpress.org/branches/5.4/wp-includes/theme-compat/footer.php

This has been deprecated, but this comment still shows up in footer code:

<!-- Gorgeous design by Michael Heilemann - http://binarybonsai.com/kubrick/ -->

Attachments (1)

50171.patch (445 bytes) - added by mukesh27 6 months ago.
Patch that remove comment message.

Download all attachments as: .zip

Change History (6)

@mukesh27
6 months ago

Patch that remove comment message.

#1 @mukesh27
6 months ago

  • Keywords has-patch added

#2 @SergeyBiryukov
6 months ago

  • Milestone changed from Awaiting Review to 5.5
  • Summary changed from HTML Comment references Kibrick to HTML Comment references Kubrick

#3 @SergeyBiryukov
6 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 47798:

Docs: Update Michael Heilemann's URL in a comment in wp-includes/theme-compat/footer.php.

Props ritterml, mukesh27.
Fixes #50171.

#4 follow-up: @ritterml
6 months ago

Why is this reference even here? My theme has nothing to do with Kubrick and this comment should not be in the core HTML.

#5 in reply to: ↑ 4 @SergeyBiryukov
6 months ago

Replying to ritterml:

Why is this reference even here? My theme has nothing to do with Kubrick and this comment should not be in the core HTML.

The files from wp-includes/theme-compat directory are indeed inherited from Kubrick, but they only exist in core for backward compatibility.

These files are only included as a fallback if your theme doesn't have a required template. If you create a footer.php file in your theme, then the one from theme-compat won't be included.

See [14365], #12425, and #13009 for more details.

Note: See TracTickets for help on using tickets.