Opened 5 years ago
Last modified 4 years ago
#50190 reopened defect (bug)
Search query doesnot know if the theme is already updated.
Reported by: | sanzeeb3 | Owned by: | |
---|---|---|---|
Milestone: | Future Release | Priority: | normal |
Severity: | normal | Version: | |
Component: | Themes | Keywords: | has-patch |
Focuses: | ui, administration | Cc: |
Description
If the theme is updated and the search box is used, there comes the 'New version available. Update Now.' again for that theme.
Attachments (1)
Change History (8)
@
5 years ago
change currently updated theme's hasUpdate prop to false as it's already updated to render it properly without showing Update Available Again...
#3
@
5 years ago
- Keywords has-patch needs-testing added
Please Guys test it on own your machine and check if its works on everywhere too! Happy WPing!!
This ticket was mentioned in Slack in #core by sajjad67. View the logs.
5 years ago
#5
@
5 years ago
- Resolution set to worksforme
- Status changed from new to closed
Yeah, the patch fixed the issue. I thought it would be a simple status check in php side.
#6
@
4 years ago
- Keywords needs-testing reporter-feedback removed
- Milestone changed from Awaiting Review to Future Release
- Resolution worksforme deleted
- Status changed from closed to reopened
Hi @sanzeeb3,
Welcome to Trac! And nice find here.
I am reopening this ticket as the change has not been committed to the codebase yet. The worksforme
resolution is confusing, and we are actually considering updating them to be more clear.
I've been able to confirm the bug using trunk
, so this still exists.
This issue also reminds me of #50291, which addressed the auto-update state not being updated across the various views of the theme. There already seems to be a function that runs on wp-theme-update-success
and tries to update version
and hasUpdate
. I'm wondering why that is not working correctly. That action is triggered right below where your patch is adding code.
Tested on local with v5.4.1 and yes it does seems to be correct... Search query doesn't know if the theme is already updated.