WordPress.org

Make WordPress Core

Opened 6 months ago

Last modified 3 days ago

#50191 new enhancement

Propose https prefix, not http for external links

Reported by: casiepa Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Editor Keywords: good-first-bug has-patch
Focuses: ui-copy Cc:

Description

In https://build.trac.wordpress.org/browser/trunk/wp-includes/class-wp-editor.php?marks=1269#L1269
The text says: The URL you entered seems to be an external link. Do you want to add the required http:// prefix?

Might be better to propose to prefix 'https://' as default.

Change History (5)

#1 @noisysocks
4 days ago

  • Focuses ui-copy added
  • Keywords needs-patch good-first-bug added

Sure, good suggestion.

#2 @noisysocks
4 days ago

  • Milestone changed from Awaiting Review to Future Release

This ticket was mentioned in PR #768 on WordPress/wordpress-develop by iamazik.


3 days ago

  • Keywords has-patch added; needs-patch removed

Update the default HTTP prefix to HTTPS as most sites now a days has SSL enabled and it's good for everything.

Trac ticket: https://core.trac.wordpress.org/ticket/50191

#4 @prbot
3 days ago

github-actions[bot] commented on PR #768:

Hi @iamazik! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

#5 @prbot
3 days ago

aristath commented on PR #768:

Patch looks good to me :+1:

Note: See TracTickets for help on using tickets.