WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #50223, comment 5


Ignore:
Timestamp:
05/23/2020 01:57:51 PM (5 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #50223, comment 5

    initial v1  
    33Unless using `array_unique()` is disallowed in WPCS (which is probably not a good idea), new instances will inevitably get added over time. Replacing some instances randomly would only cause inconsistencies and confusion, even with inline comments.
    44
     5Replying to [comment:2 Cybr]:
    56> However, I don't think we should sacrifice readability for this. A flip-flip doesn't convey that the variable is transformed to yield unique keys; I, therefore, believe these ~~rudimentary~~ low-level issues should be forwarded to the PHP Group.
    67