WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#50258 closed task (blessed) (fixed)

Update WordPress Coding Standards ruleset

Reported by: desrosj Owned by: desrosj
Priority: low Milestone: 5.5
Component: Build/Test Tools Version:
Severity: normal Keywords: has-patch has-dev-note
Cc: Focuses: coding-standards

Description

The ​WordPress Coding Standards ruleset has been ​updated to version 2.3.0.

Let's update this and related dependencies.

Attachments (2)

500258.diff​ (8.7 KB ) - added by desrosj 6 years ago.
50258.diff​ (1.9 KB ) - added by desrosj 6 years ago.

Download all attachments as: .zip

Change History (7)

@desrosj
6 years ago

#1 @desrosj
6 years ago

  • Focuses coding-standards added
  • Keywords needs-testing added
  • Owner set to desrosj
  • Status new → assigned

In my testing, I did not see any unexpected problems. Another set of eyes would be appreciated.

#2 @desrosj
6 years ago

  • Resolution → fixed
  • Status assigned → closed

In 47927:

Build/Test Tools: Update the wp-coding-standards/wpcs package.

This updates the version from 2.1.1 to 2.3.0, the latest version at this time.

Fixes #50258.

@desrosj
6 years ago

#3 @desrosj
6 years ago

  • Keywords needs-testing removed

A new check was added to the ruleset for short ternary operator syntax, which is ​not allowed per the coding standards.

50258.diff​ fixes the three occurrences of that in Core.

#4 @desrosj
6 years ago

In 47929:

Coding Standards: PHP short ternary operator syntax is not allowed.

WPCS 2.2.0 added a sniff for detecting short ternary operator syntax, which is not allowed per the Core handbook.

Follow up of [47927].
Fixes #50258.

Note: See TracTickets for help on using tickets.