Context Navigation

← Previous Ticket
Next Ticket →

#50293 closed defect (bug) (fixed)

Plugin & Themes auto-updates: add missing `aria-hidden` attributes to dashicons

Reported by:	audrasjb	Owned by:	desrosj
Priority:	normal	Milestone:	5.5
Component:	Administration	Version:	5.5
Severity:	normal	Keywords:	has-patch commit
Cc:		Focuses:	accessibility

Description

Current implementation in Plugins screen auto-updates column:

<a href="plugins.php?action=disable-auto-update…" class="toggle-auto-update" data-wp-action="disable">
    <span class="dashicons dashicons-update spin hidden"></span>
    <span class="label">Disable auto-updates</span>
</a>

span elements only used to display a dashicon should use aria-hidden attribute as it's a decorative element.

This also needs to be fixed on Themes screen.

For reference, this bug was introduced in #50052.

Attachments (1)

50293.diff (2.2 KB ) - added by ryokuhi 6 years ago.: First patch

Download all attachments as: .zip

Change History (7)

This ticket was mentioned in Slack in #accessibility by sabernhardt. View the logs.

6 years ago

@ryokuhi
6 years ago

Attachment 50293.diff added

First patch

#2 @audrasjb
6 years ago

Keywords has-patch commit added; needs-patch removed
Owner set to audrasjb
Status new → accepted

The patch looks perfect, marking this for commit. Thanks @ryokuhi

Also, additional props should go to @afercia who spotted the issue.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.

6 years ago

#4 @desrosj
6 years ago

Owner changed from audrasjb to desrosj
Status accepted → assigned

#5 @desrosj
6 years ago

Resolution → fixed
Status assigned → closed

In 47910:

Accessibility: Add the aria-hidden attribute to the auto-update related icons.

<span> elements used for displaying icons should use the aria-hidden attribute as they are purely decorative.

Props audrasjb, ryokuhi.
Fixes #50293.

This ticket was mentioned in Slack in #accessibility by nrqsnchz. View the logs.

6 years ago

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#50293 closed defect (bug) (fixed)

Plugin & Themes auto-updates: add missing `aria-hidden` attributes to dashicons

Description

Attachments (1)

Change History (7)

This ticket was mentioned in ​Slack in #accessibility by sabernhardt. ​View the logs. 6 years ago

@ryokuhi 6 years ago

#2 @audrasjb 6 years ago

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs. 6 years ago

#4 @desrosj 6 years ago

#5 @desrosj 6 years ago

This ticket was mentioned in ​Slack in #accessibility by nrqsnchz. ​View the logs. 6 years ago