WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#50293 closed defect (bug) (fixed)

Plugin & Themes auto-updates: add missing `aria-hidden` attributes to dashicons

Reported by: audrasjb's profile audrasjb Owned by: desrosj's profile desrosj
Milestone: 5.5 Priority: normal
Severity: normal Version: 5.5
Component: Administration Keywords: has-patch commit
Focuses: accessibility Cc:

Description

Current implementation in Plugins screen auto-updates column:

<a href="plugins.php?action=disable-auto-update…" class="toggle-auto-update" data-wp-action="disable">
    <span class="dashicons dashicons-update spin hidden"></span>
    <span class="label">Disable auto-updates</span>
</a>

span elements only used to display a dashicon should use aria-hidden attribute as it's a decorative element.

This also needs to be fixed on Themes screen.

For reference, this bug was introduced in #50052.

Attachments (1)

50293.diff​ (2.2 KB) - added by ryokuhi 6 years ago.
First patch

Download all attachments as: .zip

Change History (7)

This ticket was mentioned in ​Slack in #accessibility by sabernhardt. ​View the logs.
6 years ago

@ryokuhi
6 years ago

First patch

#2 @audrasjb
6 years ago

  • Keywords has-patch commit added; needs-patch removed
  • Owner set to audrasjb
  • Status changed from new to accepted

The patch looks perfect, marking this for commit. Thanks @ryokuhi

Also, additional props should go to @afercia who spotted the issue.

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
6 years ago

#4 @desrosj
6 years ago

  • Owner changed from audrasjb to desrosj
  • Status changed from accepted to assigned

#5 @desrosj
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 47910:

Accessibility: Add the aria-hidden attribute to the auto-update related icons.

<span> elements used for displaying icons should use the aria-hidden attribute as they are purely decorative.

Props audrasjb, ryokuhi.
Fixes #50293.

This ticket was mentioned in ​Slack in #accessibility by nrqsnchz. ​View the logs.
5 years ago

Note: See TracTickets for help on using tickets.