Make WordPress Core

Opened 6 years ago

Closed 2 years ago

Last modified 2 years ago

#50317 closed defect (bug) (fixed)

Twenty-Twenty: Image Block Caption alignment is not centered on mobile version

Reported by: spanglishwebs Owned by: karmatosed
Priority: normal Milestone: 6.7
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch needs-testing commit
Cc: Focuses: css

Description

Summary
The caption alignment within an Image Block does not align centre on mobile device.

Steps to Reproduce

  1. Add an Image Block with a caption to a page in the theme Twenty-Twenty
  2. Align the caption to be centred, screenshot: ​https://d.pr/i/zus1yt
  3. View page on mobile device, caption is still aligned left, screenshot: ​https://d.pr/i/Y8PxJR. But it is aligned correctly on desktop.

Expected Result
I expected the Image Block caption to also be aligned centred on mobile device.

Actual Result
Image Block caption remained aligned left on mobile, but was centred correctly on desktop view.

Additional notes
This was tested on theme Twenty-Twenty, where I could also replicate the issue on a test site. Works correctly and as expected on theme Twenty-Nineteen.

Gutenberg: 8.2.1
CoBlocks: 1.23.0

Attachments (5)

50317.patch​ (1.2 KB ) - added by sabernhardt 6 years ago.
centering .aligncenter image caption for all screen sizes
50317.1.patch​ (1.2 KB ) - added by sabernhardt 6 years ago.
another option: centering .aligncenter captions for more blocks (including image gallery, audio and table) at any screen size
50317.2.patch​ (1.3 KB ) - added by shailu25 2 years ago.
Patch Refreshed.
before-patch.png​ (96.9 KB ) - added by shailu25 2 years ago.
Before Patch
after-patch.png​ (96.6 KB ) - added by shailu25 2 years ago.
After Patch

Download all attachments as: .zip

Change History (22)

#1 @sabernhardt
6 years ago

  • Component General → Bundled Theme
  • Focuses css added

@spanglishwebs Thanks for the report!

Centering the caption starts at 1000 pixels and wider, which I did not expect either.

Centered text that wraps on multiple lines can be more difficult to read, so the theme authors might have intended to avoid that. However, if the caption is long enough to prefer left-aligned text, editors can leave the image block's alignment setting unselected.

@sabernhardt
6 years ago

centering .aligncenter image caption for all screen sizes

#2 @sabernhardt
6 years ago

The centering was added recently (47689), and ticket #49320 does not indicate that placing it inside the media query was intentional.

In case the style belongs outside the media query, for all screen sizes, I uploaded a patch.

@sabernhardt
6 years ago

another option: centering .aligncenter captions for more blocks (including image gallery, audio and table) at any screen size

#3 @sabernhardt
6 years ago

  • Keywords has-patch added

#4 @karmatosed
2 years ago

  • Keywords needs-testing added
  • Milestone Awaiting Review → Future Release

#5 @karmatosed
2 years ago

  • Keywords commit added
  • Milestone Future Release → 6.6
  • Owner set to karmatosed
  • Status new → assigned

Thank you for this. I am going to look to test and move this into commit if works as seems a great candidate to just get in.

#6 @karmatosed
2 years ago

  • Keywords commit removed

I just did some testing on this and I think it might need some iterations. What I am currently experiencing is that on mobile the centering doesn't come in at all. I would love if someone could confirm this or not so for now lets remove commit and get some more testing. Thank you everyone for your work so far and I am sure we can iterate to get a solution.

#7 @sudipatel007
2 years ago

  • Keywords needs-patch added; needs-testing has-patch removed

Patch Re-testing

@karmatosed I have applied latest patch and i am getting the same issue. I think issue is not resolved.

Screenshot - ​https://prnt.sc/s9_n0luLsLPy

Environment

  • WordPress: 6.6-beta2-58420
  • PHP: 8.1.23
  • Server: nginx/1.16.0
  • Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.23)
  • Browser: Chrome 126.0.0.0 (macOS)
  • Theme: Twenty Twenty 2.6

#8 @sabernhardt
2 years ago

  • Milestone 6.6 → 6.7

#9 @karmatosed
2 years ago

  • Keywords changes-requested has-patch added; needs-patch removed

@sudipatel007 This has a patch so should have that keyword still on it. It however if doesn't apply in testing should have it changes requested added. Thanks.

#10 @karmatosed
2 years ago

  • Milestone 6.7 → Future Release

#11 @karmatosed
2 years ago

  • Owner karmatosed removed

@shailu25
2 years ago

Patch Refreshed.

#12 @shailu25
2 years ago

I just refreshed @sabernhardt's second patch. It needed to be updated with the latest trunk.

@shailu25
2 years ago

Before Patch

@shailu25
2 years ago

After Patch

#13 @shailu25
2 years ago

  • Keywords needs-testing added; changes-requested removed

#14 @karmatosed
2 years ago

  • Owner set to karmatosed

#15 @karmatosed
2 years ago

  • Milestone Future Release → 6.7

I am going to test this now thanks.

#16 @karmatosed
2 years ago

  • Resolution → fixed
  • Status assigned → closed

In 58909:

Twenty Twenty: Fixes image block caption alignment not being centered on mobile.

The image block caption was not being centered on mobile. This was set to start at 1000 pixels and wider. This might have been intended to prevent wrapping, but you can resolve this by unselecting alignment.

Props spanglishwebs, sabernhardt, sudipatel007, shailu25.
Fixes #50317.

#17 @karmatosed
2 years ago

  • Keywords commit added
Note: See TracTickets for help on using tickets.