Misleading error message when upload of an image fails

[Presskopp]

If uploading an image fails we get the error

Could not insert post into the database

Yes, every image will have it's post, but the error message should rather say

Your file could not be uploaded for some reason

see
​https://build.trac.wordpress.org/browser/trunk/wp-includes/post.php?marks=3983#L3983

[ocean90]

The upload didn't fail in this case so your suggestion would be misleading as well. Since this is a rare error message that the end user should see we can simply replace "post" with "item".

[Shital Patel]

error message changed

[Shital Patel]

full path of src folder

[Presskopp]

@shital-patel thanks for the patch. Please change the string to:

Could not insert item into the database

[Shital Patel]

original message added

[SergeyBiryukov]

Thanks for the patch! Just noting that we have a specific message for each data type:

• Could not insert link into the database
• Could not update link in the database
• Could not insert site into the database.
• Could not update site in the database.
• Could not insert post into the database
• Could not update post in the database
• Could not insert term into the database.
• Could not insert term taxonomy into the database.
• Could not insert term relationship into the database.

So, instead of switching to a generic "item", I think it would be better to introduce two new strings for attachments:

• Could not insert attachment into the database.
• Could not update attachment in the database.

This would also be consistent with some special cases for 'attachment' === $post_type in wp_insert_post(), e.g. wp_insert_attachment_data vs wp_insert_post_data hooks and a few others.

[SergeyBiryukov]

In 47922:

Posts, Post Types: Display a more specific error message when an attachment could not be inserted into the database.

Props shital-patel, Presskopp, ocean90.
Fixes #50325.