Context Navigation

← Previous Ticket
Next Ticket →

#50352 closed enhancement (fixed)

Implement wp_cache_get_multiple() in core

Reported by:	spacedmonkey	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	5.5
Component:	Cache API	Version:	5.5
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:	performance

Description (last modified by SergeyBiryukov)

Now that wp_cache_get_multiple() was merged in [47938], it can be used in core. In the original ticket, @spacedmonkey noted some places where this function can now be used. Including

update_object_term_cache
update_meta_cache
_get_non_cached_ids

Attachments (1)

50362.diff (634 bytes ) - added by Chouby 6 years ago.

Download all attachments as: .zip

Change History (12)

This ticket was mentioned in PR #332 on WordPress/wordpress-develop by spacedmonkey.

6 years ago #1

Keywords has-patch added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/50352

#2 @spacedmonkey
6 years ago

Therer is a patch in this PR https://github.com/WordPress/wordpress-develop/pull/332

This ticket was mentioned in Slack in #hosting-community by spacedmonkey. View the logs.

6 years ago

#4 @SergeyBiryukov
6 years ago

Milestone Awaiting Review → 5.5
Owner set to SergeyBiryukov
Status new → reviewing

#5 follow-up: ↓ 7 @whyisjake
6 years ago

Resolution → fixed
Status reviewing → closed

Fixed in [48055].

whyisjake commented on PR #332:

6 years ago #6

Added in https://core.trac.wordpress.org/changeset/48055

#7 in reply to: ↑ 5 @Chouby
6 years ago

After [48055], update_object_term_cache() caches only one term due to the break instruction which has been left after the 2 foreach loops have been inverted.

Last edited 6 years ago by Chouby (previous) (diff)

#8 @Chouby
6 years ago

Resolution fixed
Status closed → reopened

@Chouby
6 years ago

Attachment 50362.diff added

#9 @SergeyBiryukov
6 years ago

Resolution → fixed
Status reopened → closed

In 48187:

Taxonomy: Make sure update_object_term_cache() caches all terms that were not already cached.

Due to an unintended break instruction from a previous iteration, the function cached only one term in each taxonomy.

Follow-up to [48055].

Props Chouby.
Fixes #50352.

#10 @spacedmonkey
4 years ago

#22174 was marked as a duplicate.

#11 @SergeyBiryukov
4 years ago

Description modified (diff)
Summary Implement wp_cache_get_multi in core → Implement wp_cache_get_multiple() in core

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#50352 closed enhancement (fixed)

Implement wp_cache_get_multiple() in core

Description (last modified by SergeyBiryukov)

Attachments (1)

Change History (12)

This ticket was mentioned in ​PR #332 on ​WordPress/wordpress-develop by ​spacedmonkey. 6 years ago #1

#2 @spacedmonkey 6 years ago

This ticket was mentioned in ​Slack in #hosting-community by spacedmonkey. ​View the logs. 6 years ago

#4 @SergeyBiryukov 6 years ago

#5 follow-up: ↓ 7 @whyisjake 6 years ago

​whyisjake commented on ​PR #332: 6 years ago #6

#7 in reply to: ↑ 5 @Chouby 6 years ago

#8 @Chouby 6 years ago

@Chouby 6 years ago

#9 @SergeyBiryukov 6 years ago

#10 @spacedmonkey 4 years ago

#11 @SergeyBiryukov 4 years ago