WordPress 2.3 doesn't finish to load when fsockopen has been disabled

[xknown]

As the title states, WP enters in an infinite loop (line 35 wp-includes/update.php) when fsockopen is listed in disable_functions directive.

The attached patch contains an alternative to fix the problem, it also restrict update checks only when is_admin() is true.

[xknown]

check if fsockopen has been disabled

[markjaquith]

Agree that we should be preventing an infinite loop -- but not that we should limit it to wp-admin. It's really close to release, let's just fix the bug.

Checking fsockopen() is good, but line 33 also troubles me because all it tests for is "false" (which obviously is failing in the case of fsockopen() being blocked). We should be testing $fs with is_resource()

[xknown]

Mark, your patch is more consistent although I don't like the idea that versions checks take place on init hook.

[markjaquith]

(In [6151]) Core and plugin update checking: make sure fsockopen() is available and check file resources with is_resource() -- both to prevent feof() infinite loops. Props xknown. fixes #5037