Opened 4 years ago
Closed 4 years ago
#50371 closed defect (bug) (fixed)
Fix WordPress 4.4 branch on Travis
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | WordPress.org | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Build/Test Tools | Keywords: | |
| Focuses: | Cc: |
Description
The automated tests for WordPress 4.4 branch started failing on May 22:
> phantomjs@1.9.19 install /home/travis/build/WordPress/wordpress-develop/node_modules/grunt-contrib-qunit/node_modules/grunt-lib-phantomjs/node_modules/phantomjs
> node install.js
Found PhantomJS at /usr/local/phantomjs/bin/phantomjs ...verifying
PhantomJS detected, but wrong version 2.1.1 @ /usr/local/phantomjs/bin/phantomjs.
Downloading https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-1.9.8-linux-x86_64.tar.bz2
Saving to /tmp/phantomjs/phantomjs-1.9.8-linux-x86_64.tar.bz2
Receiving...
Error requesting archive.
Status: 404
Request options: {
"uri": "https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-1.9.8-linux-x86_64.tar.bz2",
"encoding": null,
"followRedirect": true,
"headers": {},
"strictSSL": true
}
This went unnoticed at the time, but gained more attention with the subsequent WordPress 4.4.23 release.
The 4.3 branch attemps to download the 1.9.20 version (vs. 1.9.19), which succeeds and results in the same package from a different location:
> phantomjs@1.9.20 install /home/travis/build/WordPress/wordpress-develop/node_modules/grunt-contrib-qunit/node_modules/grunt-lib-phantomjs/node_modules/phantomjs > node install.js Considering PhantomJS found at /usr/local/phantomjs/bin/phantomjs Found PhantomJS at /usr/local/phantomjs/bin/phantomjs ...verifying PhantomJS detected, but wrong version 2.1.1 @ /usr/local/phantomjs/bin/phantomjs. Downloading https://github.com/Medium/phantomjs/releases/download/v1.9.19/phantomjs-1.9.8-linux-x86_64.tar.bz2 Saving to /tmp/phantomjs/phantomjs-1.9.8-linux-x86_64.tar.bz2 Receiving... Received 12854K total.
The 4.3 branch doesn't have the npm-shrinkwrap.json file (introduced in [36165]), which might explain the difference in version and location.
The 4.5 branch downloads a different package:
> phantomjs-prebuilt@2.1.7 install /home/travis/build/WordPress/wordpress-develop/node_modules/grunt-contrib-qunit/node_modules/grunt-lib-phantomjs/node_modules/phantomjs-prebuilt > node install.js Considering PhantomJS found at /usr/local/phantomjs/bin/phantomjs Found PhantomJS at /usr/local/phantomjs/bin/phantomjs ...verifying Writing location.js file PhantomJS is already installed on PATH at /usr/local/phantomjs/bin/phantomjs
This is because grunt-contrib-qunit (for which phantomjs-prebuilt is one of the dependencies) was bumped from 0.7.0 to 1.1.0 in [37020] / #35104.
Changelog: https://github.com/gruntjs/grunt-contrib-qunit/compare/v0.7.0...v1.1.0
Backporting [37020] to the 4.4 branch appears to be the easiest way to resolve this without any side effects.
In 48030: