WordPress.org

Make WordPress Core

Opened 3 weeks ago

Last modified 3 weeks ago

#50384 new defect (bug)

@getimagesize bug for some images: Returns empty

Reported by: samwebdev Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.4.1
Component: Media Keywords:
Focuses: Cc:

Description (last modified by SergeyBiryukov)

Hello,

Stumbled upon a bug at @getimagesize, which causes image generation to fail.

To replicate:

upload

https://n11scdn1.akamaized.net/a1/1024/elektronik/access-point-router/xiaomi-mi-wifi-pro-sinyal-yakinlastirici-guclendirici-300-mbps__0804220795448321.jpg

The original file will be available in /uploads/ folder; it browse fine in browser. Metadata generation will fail via wp_generate_attachment_metadata, hence thumbnail generations will fail.

Further checking, wp_create_image_subsizes is called, where

	$imagesize = @getimagesize( $file );

will try to get the image size, which it returns empty.

if ( empty( $imagesize ) ) {

	   // File is not an image.
           return array();
	}

will return empty array, hence wp_generate_attachment_metadata will save empty metadata, hence any file generation will be cancelled.

Manually setting imagesize where @getimagesize fails, can confirm metadata generates fine and all file regenarations work.

if ( empty( $imagesize ) ) {

		$imagesize[0] = 1024;
		$imagesize[1] = 1024;

// File is not an image.
//		return array();
	}

@getimagesize fails for some files.

Regards,

Sam

Change History (1)

#1 @SergeyBiryukov
3 weeks ago

  • Component changed from General to Media
  • Description modified (diff)
Note: See TracTickets for help on using tickets.