@getimagesize bug for some images: Returns empty

[samwebdev]

Hello,

Stumbled upon a bug at @getimagesize, which causes image generation to fail.

To replicate:

upload

​https://n11scdn1.akamaized.net/a1/1024/elektronik/access-point-router/xiaomi-mi-wifi-pro-sinyal-yakinlastirici-guclendirici-300-mbps__0804220795448321.jpg

The original file will be available in /uploads/ folder; it browse fine in browser. Metadata generation will fail via wp_generate_attachment_metadata, hence thumbnail generations will fail.

Further checking, wp_create_image_subsizes is called, where

	$imagesize = @getimagesize( $file );

will try to get the image size, which it returns empty.

if ( empty( $imagesize ) ) {

	   // File is not an image.
           return array();
	}

will return empty array, hence wp_generate_attachment_metadata will save empty metadata, hence any file generation will be cancelled.

Manually setting imagesize where @getimagesize fails, can confirm metadata generates fine and all file regenarations work.

if ( empty( $imagesize ) ) {

		$imagesize[0] = 1024;
		$imagesize[1] = 1024;

// File is not an image.
//		return array();
	}

@getimagesize fails for some files.

Regards,

Sam

[antpb]

hi @samwebdev ! Thanks for this report. Looking at the function today I notice we are using wp_getimagesize which better accounts for edge cases like these. Is it possible for you to test this again using the latest WordPress to ensure this is still happening?

Here's a link to the latest version of the code: ​https://github.com/WordPress/wordpress-develop/blob/a14324ca3af4eeff69406d3e59719a33f055f07e/src/wp-admin/includes/image.php#L237