Admin notices: error messages should not be all bold

[afercia]

Splitting this out from #47656.

While there are cases where the admin notices error messages may legitimately use bold form some terms within the message, the whole message shouldn't be bold.

The vast majority of the error admin notices are just text with a normal font weight. The <strong> element does add semantic (strong) emphasis but that's an addition that brings in very little value. Visually: the bold message is inconsistent with most of the error admin notices.

Some examples:

echo '<div class="error"><p><strong>' . __( 'You cannot install a network of sites with your server address.' ) . '</p></div>';

and

echo '<div class="error"><p><strong>' . __( 'The network could not be created.' ) . '</strong></p>';

These "all bold" admin notices should be adjusted to remove the all-bold effect.

Worth also reminding the CSS class class="error" is legacy and should be replaced with class="notice notice-error".

[ocean90]

Related: #37280

Adding Bold only on the "Error:" text.

Trac ticket: https://core.trac.wordpress.org/ticket/50402

[rajinsharwar]

As for the current trunk, I found two instances of such inconsistency. I tried to review each instance of the Error: text and make them under the STRONG, and the remaining notice message as normal text. Let me know if any other instance where this was missed.

As described in the Trac ticket below, class="error" is legacy and should be replaced with class="notice notice-error". In this PR, I have done that.

Trac ticket: https://core.trac.wordpress.org/ticket/50402

[robinmartijn]

I have updated the error classes as described in the ticket above. First time contributing, so please don't hesitate to let me know if and how I screwed up. ;-)

[mukesh27]

In #57791, we introduced admin notice functions. Could we integrate those functions into the PHP code instead of having the notice code inline?

[joedolson]

Thanks for your patches @robinmartijn and @rajinsharwar

As @mukesh27 says, we'll need to integrate the new classes into the function calls in most cases. These will also require visual inspection and screenshots to verify that any changes are acceptable.

In the wp_admin_notice() function, the classes 'notice notice-error' are automatically added by setting the type to 'error', and should be omitted from the paragraph wrapper. If there's a different class on the paragraph inside the error, those are different from the notice classes and should be retained - in most cases, they're likely needed hooks for some JS event or response.

[swissspidy]

@joedolson Is this on your radar for 6.5? It looks like a punt candidate to me.

[oglekler]

It looks like this patch needs new patch and possibly has some dependency from another ticket about errors notifications 🤔

[sabernhardt]

The dependency mentioned earlier was the wp_admin_notice() function, which is included in recent versions.

PR 5844 is closed, but I do not recommend editing the (classes for) upgrade notices in bundled themes. Those error messages only appear when trying to activate the theme in an older version of WordPress.

[chaion07]

Thanks @afercia for reporting this. We reviewed this Ticket during a recent Core Triage session. Based on the feedback received we feel the need for a specific discussion in order to move this Ticket forwards and closer to a resolution. Lets continue the discussion in the comments.

Props to @cbravobernal for the suggestion

Cheers!

[stoyangeorgiev]

This one was discussed at a few bug-scrubs and with 6.7 right around the corner, I think we can move this one for a Future-Release. It could be easily set to 6.8 at a later time.