Make WordPress Core

Opened 4 years ago

Last modified 5 days ago

#50402 accepted defect (bug)

Admin notices: error messages should not be all bold

Reported by: afercia's profile afercia Owned by: joedolson's profile joedolson
Milestone: 6.6 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: ui Cc:

Description

Splitting this out from #47656.

While there are cases where the admin notices error messages may legitimately use bold form some terms within the message, the whole message shouldn't be bold.

The vast majority of the error admin notices are just text with a normal font weight. The <strong> element does add semantic (strong) emphasis but that's an addition that brings in very little vale. Visually: the bold message is inconsistent with most of the error admin notices.

Some examples:

echo '<div class="error"><p><strong>' . __( 'You cannot install a network of sites with your server address.' ) . '</p></div>';

and

echo '<div class="error"><p><strong>' . __( 'The network could not be created.' ) . '</strong></p>';

These "all bold" admin notices should be adjusted to remove the all-bold effect.

Worth also reminding the CSS class class="error" is legacy and should be replaced with class="notice notice-error".

Change History (13)

#1 @ocean90
4 years ago

Related: #37280

This ticket was mentioned in Slack in #design by afercia. View the logs.


4 years ago

#3 @joedolson
8 months ago

  • Milestone changed from Awaiting Review to 6.5
  • Owner set to joedolson
  • Status changed from new to accepted

This ticket was mentioned in PR #5651 on WordPress/wordpress-develop by @rajinsharwar.


7 months ago
#4

  • Keywords has-patch added

Adding Bold only on the "Error:" text.

Trac ticket: https://core.trac.wordpress.org/ticket/50402

#5 @rajinsharwar
7 months ago

As for the current trunk, I found two instances of such inconsistency. I tried to review each instance of the Error: text and make them under the STRONG, and the remaining notice message as normal text. Let me know if any other instance where this was missed.

This ticket was mentioned in PR #5844 on WordPress/wordpress-develop by expedition-robin-martijn.


5 months ago
#6

As described in the Trac ticket below, class="error" is legacy and should be replaced with class="notice notice-error". In this PR, I have done that.

Trac ticket: https://core.trac.wordpress.org/ticket/50402

#7 @robinmartijn
5 months ago

I have updated the error classes as described in the ticket above. First time contributing, so please don't hesitate to let me know if and how I screwed up. ;-)

#8 @mukesh27
5 months ago

In #57791, we introduced admin notice functions. Could we integrate those functions into the PHP code instead of having the notice code inline?

#9 @joedolson
5 months ago

Thanks for your patches @robinmartijn and @rajinsharwar

As @mukesh27 says, we'll need to integrate the new classes into the function calls in most cases. These will also require visual inspection and screenshots to verify that any changes are acceptable.

In the wp_admin_notice() function, the classes 'notice notice-error' are automatically added by setting the type to 'error', and should be omitted from the paragraph wrapper. If there's a different class on the paragraph inside the error, those are different from the notice classes and should be retained - in most cases, they're likely needed hooks for some JS event or response.

#10 @swissspidy
4 months ago

@joedolson Is this on your radar for 6.5? It looks like a punt candidate to me.

#11 @swissspidy
4 months ago

  • Milestone changed from 6.5 to 6.6

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


10 days ago

This ticket was mentioned in Slack in #accessibility by rcreators. View the logs.


5 days ago

Note: See TracTickets for help on using tickets.