Auto-update errors are not displayed on the Themes screen

[azaozz]

The js expects an element with class="notice error" that doesn't exist in the theme overlay.

[azaozz]

50405.diff seems to fix this but overlaps with #50280. Will refresh after 50280 is done.

[afercia]

Good catch. Also, I think the correct usage of the class names for the admin notices is by "stacking" them e.g. notice notice-error. The class error is legacy and should not be used.

I think there's one more occurrence to adjust in WP_MS_Themes_List_Table.

Also, if I'm not wrong, these error notices may appear on a white background (depending on which row of the zebra-striped table) so I'd propose to consider the additional notice-alt class. See screenshot below (white notice on white background).

[afercia]

White notice on white background

[azaozz]

The class error is legacy and should not be used.

Right.

there's one more occurrence to adjust

Yes, fixed.

these error notices may appear on a white background (depending on which row of the zebra-striped table) so I'd propose to consider the additional notice-alt class.

Yes, sounds good.

In 50405.1.diff:

• Use the notice notice-error notice-alt inline classes for the error notices and adjust the js to match.
• Refresh the fix for displaying of error notices on the Themes screen after [48077].

[azaozz]

Plugins screen error notices with 50405.1.diff.

[azaozz]

Themes screen error notice with 50405.1.diff.

[azaozz]

In 48092:

Plugins and Themes Auto-Updates:

• Fix displaying of errors on the Themes screen.
• Correct the classes used for the error messages, and use notice-alt as notices are mostly shown on a white background.

Props afercia, azaozz.
Fixes #50405.