WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 3 weeks ago

#50414 closed defect (bug) (fixed)

Privacy policy setting page bottom, it needs to remove colon instead of Or.

Reported by: vinita29 Owned by: garrett-eclipse
Milestone: 5.6 Priority: normal
Severity: minor Version: 4.9.6
Component: Privacy Keywords: has-patch has-screenshots commit
Focuses: ui, administration Cc:

Description

In the Privacy Policy Page, the colon needs to remove with Or Before the "Create new page" button, there's no meaning of colon with Or. it needs to remove. we can show simply "Or".

Attachments (3)

Or_with_colon.png (7.1 KB) - added by vinita29 3 months ago.
50414.diff (356 bytes) - added by vinita29 3 months ago.
50414.2.diff (390 bytes) - added by garrett-eclipse 4 weeks ago.
Refresh patch to apply properly to src/wp-admin/options-general.php

Download all attachments as: .zip

Change History (7)

@vinita29
3 months ago

#1 @SergeyBiryukov
3 months ago

  • Component changed from Administration to Privacy
  • Focuses administration added

@garrett-eclipse
4 weeks ago

Refresh patch to apply properly to src/wp-admin/options-general.php

#2 @garrett-eclipse
4 weeks ago

  • Keywords has-patch has-screenshots commit added; needs-patch needs-screenshots removed
  • Milestone changed from Awaiting Review to 5.6
  • Owner set to garrett-eclipse
  • Status changed from new to accepted
  • Type changed from enhancement to defect (bug)
  • Version changed from 5.5 to 4.9.6

Thanks for the patch @vinita29 this makes sense to me and looks good to go, only minor item was the diff was made from the wp-admin folder and you'll want to make them from the root of the project above the src/ folder.
The command I usually run from there to ensure I'm just getting the source changes;
svn diff src > XXXX.X.diff

I've uploaded a refreshed patch so we can move this to commit and into the next release.

#3 @vinita29
4 weeks ago

Thanks @garrett-eclipse!

Last edited 4 weeks ago by vinita29 (previous) (diff)

#4 @helen
3 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 48965:

Privacy: Remove extraneous colon from settings screen.

Props vinita29, garrett-eclipse.
Fixes #50414.

Note: See TracTickets for help on using tickets.