Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#50415 closed defect (bug) (fixed)

Nav menu item's term validation error

Reported by: ashour's profile ashour Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: minor Version: 5.3
Component: Menus Keywords: has-patch
Focuses: Cc:


There is a wrong error validation for the menu item term existance in
wp-admin/includes/class-walker-nav-menu-edit.php: 77 start_el() function

$original_object instead of $original_title

Attachments (1)

50415#.diff (644 bytes) - added by ashour 3 years ago.
A fix for the error validation of the $original_object variable

Download all attachments as: .zip

Change History (4)

3 years ago

A fix for the error validation of the $original_object variable

#1 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 5.5
  • Version changed from trunk to 5.3

Hi there, welcome to WordPress Trac! Thanks for the report.

Good catch! Introduced in [45891], which added the new $original_object variable but missed updating the is_wp_error() check.

#2 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 48076:

Menus: Check the correct variable in Walker_Nav_Menu_Edit::start_el() when menu item is a taxonomy term.

Follow-up to [45891].

Props ashour.
Fixes #50415.

#3 @desrosj
3 years ago

  • Summary changed from Nave menu item's term validation error to Nav menu item's term validation error
Note: See TracTickets for help on using tickets.