WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#50428 closed defect (bug) (fixed)

Rename 'wp_sitemaps_is_enabled' filter

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Sitemaps Keywords: has-patch
Focuses: Cc:

Description

Background: #50117

The current name of wp_sitemaps_is_enabled doesn't read like correct English to me :)

I believe it should be wp_sitemaps_enabled, for consistency with other similar filters in core.

For reference, here's the list of filters and options with a similar purpose:

  • plugins_auto_update_enabled
  • themes_auto_update_enabled
  • rest_enabled
  • rest_jsonp_enabled
  • xmlrpc_enabled
  • wp_fatal_error_handler_enabled
  • wp_lazy_loading_enabled
  • global_terms_enabled
  • link_manager_enabled

Change History (4)

#1 @SergeyBiryukov
3 years ago

  • Component changed from General to Sitemaps

This ticket was mentioned in ​PR #342 on ​WordPress/wordpress-develop by ​helloarpitgshah.
3 years ago #2

  • Keywords has-patch added

Trac ticket:

https://core.trac.wordpress.org/ticket/50428

#3 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 48094:

Sitemaps: Rename the wp_sitemaps_is_enabled filter to wp_sitemaps_enabled.

This makes it more consistent with the other filters of the similar purpose.

Props arpitgshah.
Fixes #50428. See #50117.

This ticket was mentioned in ​Slack in #core by xhtmlpoint. ​View the logs.
3 years ago

Note: See TracTickets for help on using tickets.