WordPress.org

Make WordPress Core

Opened 8 weeks ago

Closed 7 weeks ago

Last modified 2 weeks ago

#50431 closed defect (bug) (fixed)

Update TinyMCE

Reported by: azaozz Owned by: azaozz
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: TinyMCE Keywords: has-patch needs-testing has-dev-note
Focuses: Cc:

Description

TinyMCE 4.9.10 was released recently: https://www.tiny.cloud/docs-4x/changelog/#version4910april232020, there are couple of enhancements and several bugfixes.

Attachments (1)

50431.diff (1.5 MB) - added by Hareesh Pillai 7 weeks ago.
Update TinyMCE to v4.10

Download all attachments as: .zip

Change History (7)

@Hareesh Pillai
7 weeks ago

Update TinyMCE to v4.10

#1 follow-up: @Hareesh Pillai
7 weeks ago

  • Keywords has-patch needs-testing added

Related: #47437, #48577, #47218

The above patch updates the TinyMCE library to version 4.9.10

Last edited 7 weeks ago by Hareesh Pillai (previous) (diff)

#2 follow-up: @JeffPaul
7 weeks ago

Updating to 4.9.10 seems helpful given it's the latest version in the v4 tree, however v4 hits end of life support on December 31, 2020. I know that we have #47218 to discuss updating to TinyMCE v5 (currently at 5.3.2), but instead of working to continually patch v4 this year wouldn't our efforts on TinyMCE be better focused on working on a migration to v5 (noting that @azaozz has a good summary on what's needed to update TinyMCE)?

#3 in reply to: ↑ 1 @azaozz
7 weeks ago

Replying to Hareesh Pillai:

Thanks for the patch! It's "almost there", just need to revert changes to 3.x popup windows CSS. Generally the harder part of updating TinyMCE is not replacing the files but doing the manual testing. WP extends and enhances many things with its nine custom TinyMCE plugins, and unfortunately there are only few automated tests. (I'll fix this before committing, no need to update the patch).

Last edited 7 weeks ago by azaozz (previous) (diff)

#4 in reply to: ↑ 2 @azaozz
7 weeks ago

Replying to JeffPaul:

v4 hits end of life support on December 31, 2020. I know that we have #47218 to discuss updating to TinyMCE v5 (currently at 5.3.2), but instead of working to continually patch v4 this year wouldn't our efforts on TinyMCE be better focused on working on a migration to v5

Perhaps but the work to migrate to 5.x will mostly depend on the plugin authors of WP plugins that add TinyMCE plugins :)

Unfortunately TinyMCE 5.x comes with quite a few "potentially breaking changes", see the above link to the migration guide. WP can spend the time to migrate all nine custom TinyMCE plugins, but all of the WP plugins that add TinyMCE plugins will also need updating. In that terms the migration becomes more of an "organizational task" to get the plugins authors involved.

#5 @azaozz
7 weeks ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 48158:

TinyMCE: Update to 4.9.10. Changelog: https://www.tiny.cloud/docs-4x/changelog/#version4910april232020.

Props hareesh-pillai, azaozz.
Fixes #50431.

#6 @desrosj
2 weeks ago

  • Keywords has-dev-note added

This received a call out in the Miscellaneous Developer Changes in 5.5 dev note: https://make.wordpress.org/core/2020/07/29/miscellaneous-developer-focused-changes-in-wordpress-5-5/.

Note: See TracTickets for help on using tickets.