WordPress.org

Make WordPress Core

Opened 5 months ago

Last modified 5 months ago

#50437 new task (blessed)

Add leniency to the overdue check for plugin and theme auto updates

Reported by: johnbillion Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 5.5
Component: Security Keywords: needs-patch
Focuses: Cc:

Description

The Automatic Updates column on the Plugins listing screen shows a message if a pending update for a plugin is overdue. There should be some time leniency before the message gets shown, to avoid a false positive if the cron event simply hasn't fired yet.

For example, I loaded my Plugins screen and was shown a message saying that an update was overdue by 1 second. Let's add leniency to this message so it doesn't show up within, for example, one minute of the scheduled update time.

I'm not sure if this same message is shown for themes, I've not tested it yet.

Attachments (1)

Screenshot 2020-06-20 at 11.01.16.png (22.5 KB) - added by johnbillion 5 months ago.
Screenshot

Download all attachments as: .zip

Change History (10)

#1 @johnbillion
5 months ago

  • Summary changed from Add more leniency to the overdue check for plugin and theme auto updates to Add leniency to the overdue check for plugin and theme auto updates

#2 @pbiron
5 months ago

That's a good idea.

We can add a filter, with something like 30 seconds or 1 min as the default. I'll do a patch later today/tomorrow.

#3 @peterwilsoncc
5 months ago

The site health component uses the following for considering cron jobs late and missed:

Default:

  • late: 0 seconds
  • missed: 5 minutes

DISABLE_WP_CRON set to true, ie for sites using a custom cron runner:

  • late: 15 minutes
  • missed: 1 hour

Consistency with late/missed considerations between the auto-updates and site health would be useful, if late is modified for these screens I think it would be useful to do the same for the site health component.

#4 @johnbillion
5 months ago

I feel like those settings are the wrong way around. If a site has DISABLE_WP_CRON and they're using a custom cron spawner, then the event timing accuracy should increase and therefore the tolerance should be lower, not higher.

#5 @peterwilsoncc
5 months ago

The discussion around timing occurred in #47223.

The theory I used at the time was that logging in to the dashboard should trigger a loopback firing any ready events, whereas using crontab the frequency isn't known. This ticket shows the timing needs some tuning.

This ticket was mentioned in Slack in #core by pbiron. View the logs.


5 months ago

#7 @davidbaumwald
5 months ago

  • Milestone changed from 5.5 to Future Release

With Beta 1 for 5.5 landing in just a few hours, this is being moved to Future Release. If any maintainer or committer feels this can be resolved in time, or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

#8 @SergeyBiryukov
5 months ago

  • Milestone changed from Future Release to 5.5
  • Type changed from enhancement to task (blessed)

Since this is related to the functionality that was introduced in 5.5, moving back to the milestone for now.

#9 @johnbillion
5 months ago

  • Milestone changed from 5.5 to Future Release
Note: See TracTickets for help on using tickets.