WordPress.org

Make WordPress Core

Opened 14 months ago

Closed 6 months ago

#50454 closed defect (bug) (fixed)

Twenty Twenty: ordered list styling in Classic Editor

Reported by: sabernhardt Owned by: sabernhardt
Milestone: 5.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: css Cc:

Description

This issue was originally reported by @sebastienserre on GitHub:
https://github.com/WordPress/classic-editor/issues/114

Twenty Twenty uses the square style for ordered lists when in the Classic Editor.

body#tinymce.wp-editor.content ol {
    margin-left: 1.5em;
    padding-left: 0;
    list-style: square;
}

In the main stylesheet, however, the style is set to list-style: decimal;

Attachments (2)

ordered-list-classic-editor-twenty-twenty.png (9.1 KB) - added by sabernhardt 14 months ago.
ordered list in Classic Editor
50454.patch (1.0 KB) - added by sabernhardt 14 months ago.
Sets Classic Editor's ol style to list-style: decimal;

Download all attachments as: .zip

Change History (12)

@sabernhardt
14 months ago

ordered list in Classic Editor

@sabernhardt
14 months ago

Sets Classic Editor's ol style to list-style: decimal;

#1 @sabernhardt
9 months ago

  • Milestone changed from Awaiting Review to 5.7
  • Owner set to sabernhardt
  • Status changed from new to accepted

Setting a milestone for this simple fix.

Of course, if someone wants to commit it sooner, I won't complain :)

This ticket was mentioned in Slack in #core-css by kirstyburgoine. View the logs.


9 months ago

#3 @Hareesh Pillai
7 months ago

  • Keywords dev-feedback added

Since the default value for list-style-type is decimal (for ol), wouldn't it suffice if we just remove list-style: square;?

#4 @sabernhardt
7 months ago

@hareesh-pillai The browser default might suffice for ordered lists, but this patch sets the editor styles to match the assigned front-end value.
style.css, line 487

(If removing that from the editors' styles, it would not belong on the front end either.)

This ticket was mentioned in Slack in #core-themes by poena. View the logs.


6 months ago

#6 @Hareesh Pillai
6 months ago

  • Keywords dev-feedback removed

Thanks for the clarification, @sabernhardt
The attached patch looks good to me!

This ticket was mentioned in Slack in #core by hareesh-pillai. View the logs.


6 months ago

#8 @sabernhardt
6 months ago

  • Keywords commit added

Marking for commit, according to previous comment and message on Slack #core last week

This ticket was mentioned in Slack in #core by sabernhardt. View the logs.


6 months ago

#10 @SergeyBiryukov
6 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 50275:

Twenty Twenty: Make ordered list styling in classic editor match the front-end style.

Props sabernhardt, sebastienserre, hareesh-pillai.
Fixes #50454.

Note: See TracTickets for help on using tickets.