WordPress.org

Make WordPress Core

Opened 19 months ago

Last modified 12 months ago

#50498 new defect (bug)

Change "html" to "HTML" in atomlib.php

Reported by: man4toman Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Feeds Keywords: has-patch
Focuses: docs Cc:

Description

Follow #50473, there is a string in wp-includes\atomlib.php

https://core.trac.wordpress.org/browser/tags/5.4/src/wp-includes/atomlib.php#L217

Invalid content in element found. Content must not be of type text or html if it contains markup.

Attachments (2)

50498.patch (627 bytes) - added by burhandodhy 19 months ago.
Replace html with HTML
#50498.patch (584 bytes) - added by rehanali 7 weeks ago.
Improves the documentation.Replaced the "html" with "HTML".

Download all attachments as: .zip

Change History (8)

@burhandodhy
19 months ago

Replace html with HTML

#1 @SergeyBiryukov
19 months ago

Thanks for the ticket!

Similarly to class-pclzip.php in #49163, atomlib.php used to be treated as an external library and was previously excluded from any documentation or coding standard fixes. We only modify third-party libraries when it's needed to fix a bug, like in [37461], [38883], or [39591].

That said, looking at the commit history, there were some string changes in the past.

I think it's safe to treat atomlib.php as "adopted" library rather than external. While I don't feel strongly about making this change, I don't see any harm in it either.

#2 @SergeyBiryukov
19 months ago

  • Keywords has-patch added; needs-patch removed

#3 @SergeyBiryukov
19 months ago

  • Focuses docs added

#4 @SergeyBiryukov
17 months ago

  • Component changed from General to Feeds

@rehanali
7 weeks ago

Improves the documentation.Replaced the "html" with "HTML".

Note: See TracTickets for help on using tickets.