WordPress.org

Make WordPress Core

Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#50502 closed defect (bug) (fixed)

Parameter description in update_post_meta()

Reported by: stevenlinx Owned by: SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: minor Version:
Component: Posts, Post Types Keywords: has-patch
Focuses: Cc:

Description

Attachments (1)

50502.diff (1.6 KB) - added by stevenlinx 17 months ago.

Download all attachments as: .zip

Change History (5)

@stevenlinx
17 months ago

#1 @stevenlinx
17 months ago

  • Keywords has-patch added; needs-patch removed

#2 @SergeyBiryukov
17 months ago

  • Milestone changed from Awaiting Review to 5.5

#3 @SergeyBiryukov
17 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from assigned to closed

In 48214:

Docs: Improve documentation for the $prev_value parameter and return result of various metadata update functions.

Props stevenlinx.
Fixes #50502. See #49572.

#4 @SergeyBiryukov
17 months ago

Thanks for the patch! The $prev_value and @return improvements are now in.

I'm less inclined to add that the meta key and value should be raw and not sanitized, as it's not mentioned in other similar functions and doesn't seem to come up often. If someone feels strongly about that, feel free to reopen.

Note: See TracTickets for help on using tickets.